Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)
Patch Set: update more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h
index cb87959540ba36fdba6d3cbd9eddca2db0a903d6..34f35e58a3e853964cac0081a2f5d7e6409e9130 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h
@@ -29,22 +29,20 @@ class HTMLVideoElement;
// lock was applied.
//
// The possible state transitions are:
-// - PendingFullscreen => PendingMetadata: on fullscreenchange event (entering
-// fullscreen) when metadata are not available;
-// - PendingFullscreen => MaybeLockedFullscreen: on fullscreenchange event
-// (entering fullscreen) when metadata are available;
+// - PendingFullscreen => PendingMetadata: on entering fullscreen when metadata
+// are not available;
+// - PendingFullscreen => MaybeLockedFullscreen: on entering fullscreen when
+// metadata are available;
// - PendingMetadata => MaybeLockedFullscreen: on loadedmetadata;
-// - PendingMetadata => PendingFullscreen: on fullscreenchange event (leaving
-// fullscreen);
-// - MaybeLockedFullscreen => PendingFullscreen: on fullscreenchange event
-// (leaving fullscreen).
+// - PendingMetadata => PendingFullscreen: on exiting fullscreen;
+// - MaybeLockedFullscreen => PendingFullscreen: on exiting fullscreen.
class CORE_EXPORT MediaControlsOrientationLockDelegate final
: public EventListener {
public:
explicit MediaControlsOrientationLockDelegate(HTMLVideoElement&);
- // Called by MediaControls when the HTMLMediaElement is added to a document
- // document. All event listeners should be added.
+ // Called by MediaControls when the HTMLMediaElement is added to a document.
+ // All event listeners should be added.
void attach();
// Called by MediaControls when the HTMLMediaElement is no longer in the
@@ -52,6 +50,10 @@ class CORE_EXPORT MediaControlsOrientationLockDelegate final
// object to be garbage collected.
void detach();
+ // Called by MediaControls when the fullscreen element changes.
+ void didEnterFullscreen();
+ void didExitFullscreen();
+
// EventListener implementation.
bool operator==(const EventListener&) const override;

Powered by Google App Engine
This is Rietveld 408576698