Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)
Patch Set: update more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
index 070f17b32971c62841984ede8a0b15d1d8086e8d..3e42a66d359e4b3871e0ada928be587c95ce4bb3 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
@@ -30,13 +30,6 @@ void MediaControlsMediaEventListener::attach() {
mediaElement().addEventListener(EventTypeNames::error, this, false);
mediaElement().addEventListener(EventTypeNames::loadedmetadata, this, false);
- // Listen to two different fullscreen events in order to make sure the new and
- // old APIs are handled.
- mediaElement().addEventListener(EventTypeNames::webkitfullscreenchange, this,
- false);
- m_mediaControls->document().addEventListener(EventTypeNames::fullscreenchange,
- this, false);
-
// TextTracks events.
TextTrackList* textTracks = mediaElement().textTracks();
textTracks->addEventListener(EventTypeNames::addtrack, this, false);
@@ -47,9 +40,6 @@ void MediaControlsMediaEventListener::attach() {
void MediaControlsMediaEventListener::detach() {
DCHECK(!mediaElement().isConnected());
- m_mediaControls->document().removeEventListener(
- EventTypeNames::fullscreenchange, this, false);
-
TextTrackList* textTracks = mediaElement().textTracks();
textTracks->removeEventListener(EventTypeNames::addtrack, this, false);
textTracks->removeEventListener(EventTypeNames::change, this, false);
@@ -101,16 +91,6 @@ void MediaControlsMediaEventListener::handleEvent(
return;
}
- // Fullscreen handling.
- if (event->type() == EventTypeNames::fullscreenchange ||
- event->type() == EventTypeNames::webkitfullscreenchange) {
- if (mediaElement().isFullscreen())
- m_mediaControls->onEnteredFullscreen();
- else
- m_mediaControls->onExitedFullscreen();
- return;
- }
-
// TextTracks events.
if (event->type() == EventTypeNames::addtrack ||
event->type() == EventTypeNames::removetrack) {

Powered by Google App Engine
This is Rietveld 408576698