Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)
Patch Set: update more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index 590db6ed0005814993ba95c843bdc2d4848023c6..947d4d4f9a18e65f55faeba46ff9a885520acd2e 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -68,6 +68,10 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
void enterFullscreen();
void exitFullscreen();
+ // Called by HTMLMediaElement when the fullscreen element changes.
+ void didEnterFullscreen();
+ void didExitFullscreen();
+
void showOverlayCastButtonIfNeeded();
// Update cast button visibility, but don't try to update our panel
// button visibility for space.
@@ -184,8 +188,6 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
void onTextTracksChanged();
void onError();
void onLoadedMetadata();
- void onEnteredFullscreen();
- void onExitedFullscreen();
// Internal cast related methods.
void startedCasting();

Powered by Google App Engine
This is Rietveld 408576698