Add wait to testBrowsingPostEntryWithKeyboard.

Add wait to testBrowsingPostEntryWithKeyboard.

The testBrowsingPostEntryWithKeyboard test flakes occasionally because
the omnibox's text has not updated to the next page after a form
submission. So, a wait is added to its helper method to ensure that the 
page load is completed before checking the omnibox text.

BUG=704618
Review-Url: https://codereview.chromium.org/2793233004
Cr-Commit-Position: refs/heads/master@{#462313}
Committed: https://chromium.googlesource.com/chromium/src/+/92d289e82e3aac87336b3ee2d50e830ae8fbf384

[gchatz, 2017-04-05 02:58:04]

Description was changed from

==========
Add wait to testBrowsingPostEntryWithKeyboard.

The testBrowsingPostEntryWithKeyboard test flakes occasionally because
the omnibox's text has not updated to the next page after a form
submission. So, a wait is added to ensure that the page load is
completed before checking the omnibox text.

BUG=704618
==========

to

==========
Add wait to testBrowsingPostEntryWithKeyboard.

The testBrowsingPostEntryWithKeyboard test flakes occasionally because
the omnibox's text has not updated to the next page after a form
submission. So, a wait is added to its helper method to ensure that the 
page load is completed before checking the omnibox text.

BUG=704618
==========

[gchatz, 2017-04-05 02:59:33]

gchatz@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-05 04:52:41]

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:632: [ChromeEarlGrey
waitForPageToFinishLoading];
According to API contract this method just enters the text and taps Go. It's not
suppose to wait for page load or even know that Go initiates a form submission.
Do you want to move this wait call to the test instead?

[gchatz, 2017-04-05 23:43:53]

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:632: [ChromeEarlGrey
waitForPageToFinishLoading];
On 2017/04/05 04:52:41, Eugene But wrote:
> According to API contract this method just enters the text and taps Go. It's
not
> suppose to wait for page load or even know that Go initiates a form
submission.
> Do you want to move this wait call to the test instead?

In order for Go to be in the keyboard, the textfield is linked to a form
submission. I would prefer to just specify this in the comments, and leave the
wait here.

[Eugene But (OOO till 7-30), 2017-04-06 00:28:18]

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2793233004/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:632: [ChromeEarlGrey
waitForPageToFinishLoading];
On 2017/04/05 23:43:53, gchatz wrote:
> On 2017/04/05 04:52:41, Eugene But wrote:
> > According to API contract this method just enters the text and taps Go. It's
> not
> > suppose to wait for page load or even know that Go initiates a form
> submission.
> > Do you want to move this wait call to the test instead?
> 
> In order for Go to be in the keyboard, the textfield is linked to a form
> submission. I would prefer to just specify this in the comments, and leave the
> wait here. 
The method name is |openKeyboardAndTapGoButtonWithTextFieldID:|, so it does not
imply form submission or waiting for the load to finish. If you want this method
to wait, then how about renaming it to reflect it's actual functionality (form
submission)?

[Eugene But (OOO till 7-30), 2017-04-06 00:56:03]

per offline discussion lgtm with the name change

[gchatz, 2017-04-06 01:25:42]

The CQ bit was checked by gchatz@chromium.org

[gchatz, 2017-04-06 01:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2793233004/#ps40001
(title: "edit naming")

[commit-bot: I haz the power, 2017-04-06 01:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:38:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491441942991080,
"parent_rev": "67d0cd0e97bb647deaf65a7adb3dfc76ff71dacc", "commit_rev":
"92d289e82e3aac87336b3ee2d50e830ae8fbf384"}

[commit-bot: I haz the power, 2017-04-06 01:38:58]

Description was changed from

==========
Add wait to testBrowsingPostEntryWithKeyboard.

The testBrowsingPostEntryWithKeyboard test flakes occasionally because
the omnibox's text has not updated to the next page after a form
submission. So, a wait is added to its helper method to ensure that the 
page load is completed before checking the omnibox text.

BUG=704618
==========

to

==========
Add wait to testBrowsingPostEntryWithKeyboard.

The testBrowsingPostEntryWithKeyboard test flakes occasionally because
the omnibox's text has not updated to the next page after a form
submission. So, a wait is added to its helper method to ensure that the 
page load is completed before checking the omnibox text.

BUG=704618

Review-Url: https://codereview.chromium.org/2793233004
Cr-Commit-Position: refs/heads/master@{#462313}
Committed:
https://chromium.googlesource.com/chromium/src/+/92d289e82e3aac87336b3ee2d50e...
==========

[commit-bot: I haz the power, 2017-04-06 01:38:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/92d289e82e3aac87336b3ee2d50e...