|
Revert of [typedarrays] Check detached buffer at start of typed array methods (patchset #10 id:180001 of https://codereview.chromium.org/2778623003/ )
Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/18499
Changes:
https://storage.googleapis.com/chromium-layout-test-archives/v8_linux_blink_rel/18499/layout-test-results/results.html
See:
https://github.com/v8/v8/wiki/Blink-layout-tests
Original issue's description:
> [typedarrays] Check detached buffer at start of typed array methods
>
> - Throw TypeError in ValidateTypedArray, matching JSC, SpiderMonkey
> and ChakraCore.
> - Validate typed arrays at start of each typed array prototype
> methods in src/js/typedarrays.js
> - Add tests to check detached buffers
> - Remove an unnecessary parameter of TypedArraySpeciesCreate
> in src/js/typedarrays.js
> - Standardize TypedArray.prototype.subarray
> - Update test262.status to pass detached buffer tests
>
> BUG= v8:4648, v8:4665, v8:4953
>
> Review-Url: https://codereview.chromium.org/2778623003
> Cr-Commit-Position: refs/heads/master@{#44357}
> Committed: https://chromium.googlesource.com/v8/v8/+/238d5b4453d9166aaddce76a5393514d977238d4
TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,littledan@chromium.org,petermarshall@chromium.org,cwhan.tunz@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:4648, v8:4665, v8:4953
Review-Url: https://codereview.chromium.org/2793233003
Cr-Commit-Position: refs/heads/master@{#44362}
Committed: https://chromium.googlesource.com/v8/v8/+/68c14892cbf1ec2e6fb52752c79a3313e0b33786
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+99 lines, -263 lines) |
Patch |
|
M |
src/builtins/builtins-typedarray.cc
|
View
|
|
4 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-intrinsic-lowering.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/compiler/js-intrinsic-lowering.cc
|
View
|
|
2 chunks |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen.cc
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/js/typedarray.js
|
View
|
|
18 chunks |
+26 lines, -26 lines |
0 comments
|
Download
|
|
M |
src/objects-inl.h
|
View
|
|
1 chunk |
+2 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.h
|
View
|
|
1 chunk |
+13 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-typedarray.cc
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-copywithin.js
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-every.js
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-fill.js
|
View
|
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-find.js
|
View
|
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-findindex.js
|
View
|
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-foreach.js
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-indexing.js
|
View
|
|
4 chunks |
+0 lines, -21 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-iteration.js
|
View
|
|
4 chunks |
+0 lines, -17 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-reduce.js
|
View
|
|
2 chunks |
+1 line, -17 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-reverse.js
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-slice.js
|
View
|
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-sort.js
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/es6/typedarray-tostring.js
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/regress/regress-353004.js
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
test/mjsunit/regress/regress-4665.js
|
View
|
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
|
M |
test/test262/test262.status
|
View
|
|
3 chunks |
+35 lines, -0 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|