Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2793203002:
[DevTools] Pass sidebar and not the panel. (Closed)
|
Created:
3 years, 8 months ago by eostroukhov Modified:
3 years, 8 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Pass sidebar and not the panel.
BUG=707950
Review-Url: https://codereview.chromium.org/2793203002
Cr-Commit-Position: refs/heads/master@{#462096}
Committed: https://chromium.googlesource.com/chromium/src/+/de3db7c8aa94857f8360b94b66dfaa3d3caf51ce
Patch Set 1 #
Total comments: 2
Patch Set 2 : [DevTools] Pass sidebar and not the panel. #Messages
Total messages: 28 (19 generated)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
eostroukhov@chromium.org changed reviewers: + caseq@chromium.org, dgozman@chromium.org, einbinder@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Please be more specific in description. There are a lot of sidebars and panels in DevTools, and some of them are being passed around. https://codereview.chromium.org/2793203002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js (right): https://codereview.chromium.org/2793203002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:614: console.assert(storagePanel); It is marked as non-nullable. Don't assert.
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks. Updated, please take another look. https://codereview.chromium.org/2793203002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js (right): https://codereview.chromium.org/2793203002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:614: console.assert(storagePanel); On 2017/04/04 16:48:30, dgozman wrote: > It is marked as non-nullable. Don't assert. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by eostroukhov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from einbinder@chromium.org Link to the patchset: https://codereview.chromium.org/2793203002/#ps20001 (title: "[DevTools] Pass sidebar and not the panel.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491408275024350,
"parent_rev": "89bc1777299ce7c71eddb9a1144335f7cf30bdde", "commit_rev":
"de3db7c8aa94857f8360b94b66dfaa3d3caf51ce"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Pass sidebar and not the panel. BUG=707950 ========== to ========== [DevTools] Pass sidebar and not the panel. BUG=707950 Review-Url: https://codereview.chromium.org/2793203002 Cr-Commit-Position: refs/heads/master@{#462096} Committed: https://chromium.googlesource.com/chromium/src/+/de3db7c8aa94857f8360b94b66df... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/de3db7c8aa94857f8360b94b66df... |
