Remove mutable from ComputedStyle by const_cast.

Remove mutable from ComputedStyle by const_cast.

This patch removes mutable from ComputedStyle::hasViewportUnits and
hasRemUnits. The only case where this mutability is required is in
CSSToLengthConversionData, where resolving a viewport/rem unit would
set those two members to true on a const ComputedStyle. Instead of
having mutable in ComputedStyle, which is hard to generate, we perform
const_cast on the computed style in CSSToLengthConversionData. This is
safe as all computed styles are initially nonconst.

This patch does not change any behaviour.

This is prework for generating the two fields in ComputedStyleBase.

BUG=628043
Review-Url: https://codereview.chromium.org/2793193004
Cr-Commit-Position: refs/heads/master@{#462258}
Committed: https://chromium.googlesource.com/chromium/src/+/5b97f21d9cd473b57b8ce169f75d9cdc135184fc

[shend, 2017-04-05 05:13:48]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-04-05 05:13:49]

Hi Alan, PTAL :)

[alancutter (OOO until 2018), 2017-04-05 05:21:19]

lgtm, the description should make it clear there are no behavioural changes
intended.

[alancutter (OOO until 2018), 2017-04-05 05:22:23]

https://codereview.chromium.org/2793193004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp (right):

https://codereview.chromium.org/2793193004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp:101:
const_cast<ComputedStyle*>(m_style)->setHasViewportUnits();
Let's add a TODO to plumb these bits through as output parameters instead of
const_casting.

[shend, 2017-04-05 05:52:18]

Description was changed from

==========
Remove mutable from ComputedStyle by const_cast.

This patch removes mutable from ComputedStyle::hasViewportUnits and
hasRemUnits. The only case where this mutability is required is in
CSSToLengthConversionData, where resolving a viewport/rem unit would
set those two members to true on a const ComputedStyle. Instead of
having mutable in ComputedStyle, which is hard to generate, we perform
const_cast on the computed style in CSSToLengthConversionData. This is
safe as all computed styles are initially nonconst.

This is prework for generating the two fields in ComputedStyleBase.

BUG=628043
==========

to

==========
Remove mutable from ComputedStyle by const_cast.

This patch removes mutable from ComputedStyle::hasViewportUnits and
hasRemUnits. The only case where this mutability is required is in
CSSToLengthConversionData, where resolving a viewport/rem unit would
set those two members to true on a const ComputedStyle. Instead of
having mutable in ComputedStyle, which is hard to generate, we perform
const_cast on the computed style in CSSToLengthConversionData. This is
safe as all computed styles are initially nonconst.

This patch does not change any behaviour.

This is prework for generating the two fields in ComputedStyleBase.

BUG=628043
==========

[shend, 2017-04-05 05:54:51]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 05:54:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-04-05 06:19:11]

https://codereview.chromium.org/2793193004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp (right):

https://codereview.chromium.org/2793193004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp:101:
const_cast<ComputedStyle*>(m_style)->setHasViewportUnits();
On 2017/04/05 at 05:22:23, alancutter wrote:
> Let's add a TODO to plumb these bits through as output parameters instead of
const_casting.

Done.

[commit-bot: I haz the power, 2017-04-05 09:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 09:39:29]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-05 22:58:09]

The CQ bit was checked by shend@chromium.org

[shend, 2017-04-05 22:58:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2793193004/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-05 22:58:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491433089516170,
"parent_rev": "5a7bb5e2821e5be66828f155ab71fb2c2738c7cb", "commit_rev":
"5b97f21d9cd473b57b8ce169f75d9cdc135184fc"}

[commit-bot: I haz the power, 2017-04-05 23:10:19]

Description was changed from

==========
Remove mutable from ComputedStyle by const_cast.

This patch removes mutable from ComputedStyle::hasViewportUnits and
hasRemUnits. The only case where this mutability is required is in
CSSToLengthConversionData, where resolving a viewport/rem unit would
set those two members to true on a const ComputedStyle. Instead of
having mutable in ComputedStyle, which is hard to generate, we perform
const_cast on the computed style in CSSToLengthConversionData. This is
safe as all computed styles are initially nonconst.

This patch does not change any behaviour.

This is prework for generating the two fields in ComputedStyleBase.

BUG=628043
==========

to

==========
Remove mutable from ComputedStyle by const_cast.

This patch removes mutable from ComputedStyle::hasViewportUnits and
hasRemUnits. The only case where this mutability is required is in
CSSToLengthConversionData, where resolving a viewport/rem unit would
set those two members to true on a const ComputedStyle. Instead of
having mutable in ComputedStyle, which is hard to generate, we perform
const_cast on the computed style in CSSToLengthConversionData. This is
safe as all computed styles are initially nonconst.

This patch does not change any behaviour.

This is prework for generating the two fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2793193004
Cr-Commit-Position: refs/heads/master@{#462258}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b97f21d9cd473b57b8ce169f75d...
==========

[commit-bot: I haz the power, 2017-04-05 23:10:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b97f21d9cd473b57b8ce169f75d...