Update Espresso to be compatible with guava-20

Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be compatible with guava-20

BUG=704371
Review-Url: https://codereview.chromium.org/2793193002
Cr-Commit-Position: refs/heads/master@{#463744}
Committed: https://chromium.googlesource.com/chromium/src/+/6c66a4bbe7ad2b59f34b53f718f1d031cd835d75

[aluo, 2017-04-03 22:37:06]

Description was changed from

==========
Fix Espresso dependency to guava-18.0

https://codereview.chromium.org/2710343003 updated third_party/guava to 20 which
is not compatible with Espresso.  Need
to use version 18.0 for Espresso tests.

BUG=704371
==========

to

==========
Fix Espresso dependency to guava-18.0

https://codereview.chromium.org/2710343003 updated third_party/guava to 20 which
is not compatible with Espresso.  Need
to use version 18.0 for Espresso tests.

BUG=704371
==========

[aluo, 2017-04-03 22:37:06]

aluo@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, yolandyan@chromium.org

[aluo, 2017-04-05 17:02:19]

Ping

[mikecase (-- gone --), 2017-04-05 17:38:48]

uggggggggggggggggggggghhhh, you are right.

I would vote for having a //third_party/guava:guava_18_java target with a
comment that we still have it for compatibility with Espresso. That way, all the
proper license files and readme files are alongside the jar.

Might have to update //third_party/.gitignore as well to include the guava 18
jar

[jbudorick, 2017-04-05 17:42:32]

On 2017/04/05 17:38:48, mikecase wrote:
> uggggggggggggggggggggghhhh, you are right.
> 
> I would vote for having a //third_party/guava:guava_18_java target with a
> comment that we still have it for compatibility with Espresso. That way, all
the
> proper license files and readme files are alongside the jar.
> 
> Might have to update //third_party/.gitignore as well to include the guava 18
> jar

Why is espresso not compatible with 20?

I'd strongly prefer only having a single version of a third-party lib at a time
if possible.

[mikecase (-- gone --), 2017-04-05 17:46:52]

I got this locally....

C    7.004s Main  java.lang.NoSuchMethodError: No static method
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
in class Lcom/google/common/util/concurrent/Futures; or its super classes

Seems like they renamed some methods, breaking Espresso. transform() is now
transformAsync() for example...
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76

[mikecase (-- gone --), 2017-04-05 17:48:42]

On 2017/04/05 at 17:46:52, mikecase wrote:
> I got this locally....
> 
> C    7.004s Main  java.lang.NoSuchMethodError: No static method
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
in class Lcom/google/common/util/concurrent/Futures; or its super classes
> 
> Seems like they renamed some methods, breaking Espresso. transform() is now
transformAsync() for example...
>
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76

Commit I linked didnt break it I guess, but they removed the transform() method
later.

[the real yoland, 2017-04-06 18:28:49]

On 2017/04/05 at 17:48:42, mikecase wrote:
> On 2017/04/05 at 17:46:52, mikecase wrote:
> > I got this locally....
> > 
> > C    7.004s Main  java.lang.NoSuchMethodError: No static method
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
in class Lcom/google/common/util/concurrent/Futures; or its super classes
> > 
> > Seems like they renamed some methods, breaking Espresso. transform() is now
transformAsync() for example...
> >
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76
> 
> Commit I linked didnt break it I guess, but they removed the transform()
method later.

We can potentially fix that up and compile a custom espresso jar that uses
transformAsync() instead of transform()

There are only 1 class with one call using transform() with an AsyncFunction.

Based on a quick check on the guava release notes, of all the APIs that got
removed, transform() is the only function that was used in espresso.

However, other APIs that are changed instead of removed might affect the
espresso. But since it might take a long time for espresso to support guava 20,
a customized espresso jar should be better than having two guava targets in
third_party that people can depend on.

[aluo, 2017-04-06 21:29:31]

On 2017/04/06 18:28:49, the real yoland wrote:
> On 2017/04/05 at 17:48:42, mikecase wrote:
> > On 2017/04/05 at 17:46:52, mikecase wrote:
> > > I got this locally....
> > > 
> > > C    7.004s Main  java.lang.NoSuchMethodError: No static method
>
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
> in class Lcom/google/common/util/concurrent/Futures; or its super classes
> > > 
> > > Seems like they renamed some methods, breaking Espresso. transform() is
now
> transformAsync() for example...
> > >
>
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76
> > 
> > Commit I linked didnt break it I guess, but they removed the transform()
> method later.
> 
> We can potentially fix that up and compile a custom espresso jar that uses
> transformAsync() instead of transform()
> 
> There are only 1 class with one call using transform() with an AsyncFunction.
> 
> Based on a quick check on the guava release notes, of all the APIs that got
> removed, transform() is the only function that was used in espresso.
> 
> However, other APIs that are changed instead of removed might affect the
> espresso. But since it might take a long time for espresso to support guava
20,
> a customized espresso jar should be better than having two guava targets in
> third_party that people can depend on.

Let me try this, in the meantime I've moved the guava target to
third_party/guava

[aluo, 2017-04-07 01:01:42]

On 2017/04/05 17:38:48, mikecase wrote:
> uggggggggggggggggggggghhhh, you are right.
> 
> I would vote for having a //third_party/guava:guava_18_java target with a
> comment that we still have it for compatibility with Espresso. That way, all
the
> proper license files and readme files are alongside the jar.
> 
> Might have to update //third_party/.gitignore as well to include the guava 18
> jar

Does Roboelectric work with Guava 19.0 by any chance?

[aluo, 2017-04-11 00:49:33]

Description was changed from

==========
Fix Espresso dependency to guava-18.0

https://codereview.chromium.org/2710343003 updated third_party/guava to 20 which
is not compatible with Espresso.  Need
to use version 18.0 for Espresso tests.

BUG=704371
==========

to

==========
Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be
compatible with guava-20

BUG=704371
==========

[aluo, 2017-04-11 00:50:59]

Description was changed from

==========
Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be
compatible with guava-20

BUG=704371
==========

to

==========
Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be
compatible with guava-20

BUG=704371
==========

[aluo, 2017-04-11 00:52:16]

On 2017/04/06 18:28:49, the real yoland wrote:
> On 2017/04/05 at 17:48:42, mikecase wrote:
> > On 2017/04/05 at 17:46:52, mikecase wrote:
> > > I got this locally....
> > > 
> > > C    7.004s Main  java.lang.NoSuchMethodError: No static method
>
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
> in class Lcom/google/common/util/concurrent/Futures; or its super classes
> > > 
> > > Seems like they renamed some methods, breaking Espresso. transform() is
now
> transformAsync() for example...
> > >
>
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76
> > 
> > Commit I linked didnt break it I guess, but they removed the transform()
> method later.
> 
> We can potentially fix that up and compile a custom espresso jar that uses
> transformAsync() instead of transform()
> 
> There are only 1 class with one call using transform() with an AsyncFunction.
> 
> Based on a quick check on the guava release notes, of all the APIs that got
> removed, transform() is the only function that was used in espresso.
> 
> However, other APIs that are changed instead of removed might affect the
> espresso. But since it might take a long time for espresso to support guava
20,
> a customized espresso jar should be better than having two guava targets in
> third_party that people can depend on.

Updated espresso to use the new transformAsync api and uploaded the no-dep.jars
to chromium-espresso bucket.  Tests all passed locally.

[mikecase (-- gone --), 2017-04-11 01:05:40]

On 2017/04/11 at 00:52:16, aluo wrote:
> On 2017/04/06 18:28:49, the real yoland wrote:
> > On 2017/04/05 at 17:48:42, mikecase wrote:
> > > On 2017/04/05 at 17:46:52, mikecase wrote:
> > > > I got this locally....
> > > > 
> > > > C    7.004s Main  java.lang.NoSuchMethodError: No static method
> >
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
> > in class Lcom/google/common/util/concurrent/Futures; or its super classes
> > > > 
> > > > Seems like they renamed some methods, breaking Espresso. transform() is
now
> > transformAsync() for example...
> > > >
> >
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76
> > > 
> > > Commit I linked didnt break it I guess, but they removed the transform()
> > method later.
> > 
> > We can potentially fix that up and compile a custom espresso jar that uses
> > transformAsync() instead of transform()
> > 
> > There are only 1 class with one call using transform() with an
AsyncFunction.
> > 
> > Based on a quick check on the guava release notes, of all the APIs that got
> > removed, transform() is the only function that was used in espresso.
> > 
> > However, other APIs that are changed instead of removed might affect the
> > espresso. But since it might take a long time for espresso to support guava
20,
> > a customized espresso jar should be better than having two guava targets in
> > third_party that people can depend on.
> 
> Updated espresso to use the new transformAsync api and uploaded the
no-dep.jars to chromium-espresso bucket.  Tests all passed locally.

Awesome that it worked. Modify the README.chromium file to list out the local
modifications you made.

[the real yoland, 2017-04-11 01:23:17]

this should also remove previous 2.2 jar's sha1 files.

[aluo, 2017-04-11 16:42:24]

On 2017/04/11 01:05:40, mikecase wrote:
> On 2017/04/11 at 00:52:16, aluo wrote:
> > On 2017/04/06 18:28:49, the real yoland wrote:
> > > On 2017/04/05 at 17:48:42, mikecase wrote:
> > > > On 2017/04/05 at 17:46:52, mikecase wrote:
> > > > > I got this locally....
> > > > > 
> > > > > C    7.004s Main  java.lang.NoSuchMethodError: No static method
> > >
>
transform(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/AsyncFunction;)Lcom/google/common/util/concurrent/ListenableFuture;
> > > in class Lcom/google/common/util/concurrent/Futures; or its super classes
> > > > > 
> > > > > Seems like they renamed some methods, breaking Espresso. transform()
is
> now
> > > transformAsync() for example...
> > > > >
> > >
>
https://github.com/google/guava/commit/2a18d13799f5de8bd39c25a5f51de859ef979e76
> > > > 
> > > > Commit I linked didnt break it I guess, but they removed the transform()
> > > method later.
> > > 
> > > We can potentially fix that up and compile a custom espresso jar that uses
> > > transformAsync() instead of transform()
> > > 
> > > There are only 1 class with one call using transform() with an
> AsyncFunction.
> > > 
> > > Based on a quick check on the guava release notes, of all the APIs that
got
> > > removed, transform() is the only function that was used in espresso.
> > > 
> > > However, other APIs that are changed instead of removed might affect the
> > > espresso. But since it might take a long time for espresso to support
guava
> 20,
> > > a customized espresso jar should be better than having two guava targets
in
> > > third_party that people can depend on.
> > 
> > Updated espresso to use the new transformAsync api and uploaded the
> no-dep.jars to chromium-espresso bucket.  Tests all passed locally.
> 
> Awesome that it worked. Modify the README.chromium file to list out the local
> modifications you made.

done

[aluo, 2017-04-11 16:42:37]

On 2017/04/11 01:23:17, the real yoland wrote:
> this should also remove previous 2.2 jar's sha1 files.

done

[aluo, 2017-04-11 16:43:45]

The CQ bit was checked by aluo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 16:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mikecase (-- gone --), 2017-04-11 16:54:32]

Probably also want to modify third_party/.gitignore to specifically list out the
new jars you are adding. Otherwise, the stale unused jars will stay around
forever (since gitignore will hide them, and devs won't ever delete them)

Otherwise, this look good t0 me

https://codereview.chromium.org/2793193002/diff/80001/third_party/espresso/RE...
File third_party/espresso/README.chromium (right):

https://codereview.chromium.org/2793193002/diff/80001/third_party/espresso/RE...
third_party/espresso/README.chromium:18: in
android/support/test/espresso/web/action/JavascriptEvaluation.java
Although its pretty clear why you do this from the next bullet, probably just
add ...."to make Espresso compatible with Guava 20.0"

[aluo, 2017-04-11 17:02:44]

On 2017/04/11 16:54:32, mikecase wrote:
> Probably also want to modify third_party/.gitignore to specifically list out
the
> new jars you are adding. Otherwise, the stale unused jars will stay around
> forever (since gitignore will hide them, and devs won't ever delete them)
> 
> Otherwise, this look good t0 me
> 
>
https://codereview.chromium.org/2793193002/diff/80001/third_party/espresso/RE...
> File third_party/espresso/README.chromium (right):
> 
>
https://codereview.chromium.org/2793193002/diff/80001/third_party/espresso/RE...
> third_party/espresso/README.chromium:18: in
> android/support/test/espresso/web/action/JavascriptEvaluation.java
> Although its pretty clear why you do this from the next bullet, probably just
> add ...."to make Espresso compatible with Guava 20.0"

done

[aluo, 2017-04-11 17:39:59]

The CQ bit was checked by aluo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-11 19:16:51]

lgtm

[aluo, 2017-04-11 19:19:35]

The CQ bit was unchecked by aluo@chromium.org

[aluo, 2017-04-11 19:34:17]

The CQ bit was checked by aluo@chromium.org

[commit-bot: I haz the power, 2017-04-11 19:35:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:11:31]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491939257042040,
"parent_rev": "6f8338563d358a5f49940f6d75f73d7f4f94b405", "commit_rev":
"6c66a4bbe7ad2b59f34b53f718f1d031cd835d75"}

[commit-bot: I haz the power, 2017-04-11 20:12:22]

Description was changed from

==========
Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be
compatible with guava-20

BUG=704371
==========

to

==========
Update Espresso to be compatible with guava-20

https://codereview.chromium.org/2710343003 updated third_party/espresso to be
compatible with guava-20

BUG=704371

Review-Url: https://codereview.chromium.org/2793193002
Cr-Commit-Position: refs/heads/master@{#463744}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c66a4bbe7ad2b59f34b53f718f1...
==========

[commit-bot: I haz the power, 2017-04-11 20:12:23]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6c66a4bbe7ad2b59f34b53f718f1...