Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2793163002: Do not embed is_auto_setup_scope into the compilation of native calls. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not embed is_auto_setup_scope into the compilation of native calls. Rather, split NativeCallWrapper into variants that do or do not set up an API scope. This makes it safe for lazy link natives to also lazily resolve. Issue #24686 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cbb8519a695d02c44abc45b9c9185c74f0b4f486

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -136 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/constants_dbc.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +8 lines, -3 lines 2 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +8 lines, -3 lines 1 comment Download
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +8 lines, -3 lines 1 comment Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/vm/native_arguments.h View 4 chunks +0 lines, -13 lines 0 comments Download
M runtime/vm/native_entry.h View 3 chunks +23 lines, -5 lines 0 comments Download
M runtime/vm/native_entry.cc View 7 chunks +84 lines, -42 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 5 chunks +60 lines, -17 lines 0 comments Download
M runtime/vm/stub_code.h View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
3 years, 8 months ago (2017-04-03 22:02:57 UTC) #2
zra
https://codereview.chromium.org/2793163002/diff/40001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/2793163002/diff/40001/runtime/vm/intermediate_language_arm.cc#newcode984 runtime/vm/intermediate_language_arm.cc:984: entry, Simulator::kBootstrapNativeCall, NativeEntry::kNumArguments); Is there any change needed to ...
3 years, 8 months ago (2017-04-04 15:00:45 UTC) #3
rmacnak
https://codereview.chromium.org/2793163002/diff/40001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/2793163002/diff/40001/runtime/vm/intermediate_language_arm.cc#newcode984 runtime/vm/intermediate_language_arm.cc:984: entry, Simulator::kBootstrapNativeCall, NativeEntry::kNumArguments); On 2017/04/04 15:00:44, zra wrote: > ...
3 years, 8 months ago (2017-04-04 19:25:41 UTC) #4
zra
lgtm
3 years, 8 months ago (2017-04-04 19:49:19 UTC) #5
rmacnak
3 years, 8 months ago (2017-04-05 22:30:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
cbb8519a695d02c44abc45b9c9185c74f0b4f486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698