Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: runtime/vm/native_arguments.h

Issue 2793163002: Do not embed is_auto_setup_scope into the compilation of native calls. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/native_arguments.h
diff --git a/runtime/vm/native_arguments.h b/runtime/vm/native_arguments.h
index c63e2c6cc378328394b488db7fba41eb1f56369f..23f61c790796ffd7689c6bbc409778f20025d6a5 100644
--- a/runtime/vm/native_arguments.h
+++ b/runtime/vm/native_arguments.h
@@ -114,10 +114,6 @@ class NativeArguments {
return *arg_ptr;
}
- bool IsNativeAutoSetupScope() const {
- return AutoSetupScopeBits::decode(argc_tag_);
- }
-
int NativeArgCount() const {
int function_bits = FunctionBits::decode(argc_tag_);
return ArgCount() - NumHiddenArgs(function_bits);
@@ -163,9 +159,6 @@ class NativeArguments {
static intptr_t retval_offset() {
return OFFSET_OF(NativeArguments, retval_);
}
- static intptr_t AutoSetupScopeMask() {
- return AutoSetupScopeBits::mask_in_place();
- }
static intptr_t ParameterCountForResolution(const Function& function) {
ASSERT(function.is_native());
@@ -193,9 +186,6 @@ class NativeArguments {
function_bits |= kClosureFunctionBit;
}
tag = FunctionBits::update(function_bits, tag);
- if (function.IsNativeAutoSetupScope()) {
- tag = AutoSetupScopeBits::update(1, tag);
- }
return tag;
}
@@ -209,13 +199,10 @@ class NativeArguments {
kArgcSize = 24,
kFunctionBit = 24,
kFunctionSize = 2,
- kAutoSetupScopeBit = 26,
};
class ArgcBits : public BitField<intptr_t, int32_t, kArgcBit, kArgcSize> {};
class FunctionBits
: public BitField<intptr_t, int, kFunctionBit, kFunctionSize> {};
- class AutoSetupScopeBits
- : public BitField<intptr_t, int, kAutoSetupScopeBit, 1> {};
friend class Api;
friend class BootstrapNatives;
friend class Simulator;

Powered by Google App Engine
This is Rietveld 408576698