Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: courgette/disassembler.cc

Issue 2793153003: [Courgette] Refactor: Store Label Annotation in AssemblyProgram for patch generation. (Closed)
Patch Set: Rename *_label_annotation to *_label_annotations. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32_x86_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler.cc
diff --git a/courgette/disassembler.cc b/courgette/disassembler.cc
index 31c23f1f64020c67c78abccf011103517922b76a..64ca27400aa06c944df5e9f9291b436b1178add2 100644
--- a/courgette/disassembler.cc
+++ b/courgette/disassembler.cc
@@ -54,7 +54,8 @@ const uint8_t* Disassembler::RVAToPointer(RVA rva) const {
return FileOffsetToPointer(file_offset);
}
-std::unique_ptr<AssemblyProgram> Disassembler::Disassemble() {
+std::unique_ptr<AssemblyProgram> Disassembler::Disassemble(
+ bool annotate_labels) {
if (!ok() || !ExtractAbs32Locations() || !ExtractRel32Locations())
return nullptr;
@@ -64,8 +65,10 @@ std::unique_ptr<AssemblyProgram> Disassembler::Disassemble() {
PrecomputeLabels(program.get());
RemoveUnusedRel32Locations(program.get());
- if (!program->GenerateInstructions(GetInstructionGenerator(program.get())))
+ if (!program->GenerateInstructions(GetInstructionGenerator(program.get()),
+ annotate_labels)) {
return nullptr;
+ }
program->DefaultAssignIndexes();
return program;
« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32_x86_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698