Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: courgette/disassembler.cc

Issue 2793153003: [Courgette] Refactor: Store Label Annotation in AssemblyProgram for patch generation. (Closed)
Patch Set: Rename *_label_annotation to *_label_annotations. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32_x86_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "courgette/disassembler.h" 5 #include "courgette/disassembler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "courgette/assembly_program.h" 9 #include "courgette/assembly_program.h"
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 } 47 }
48 48
49 const uint8_t* Disassembler::RVAToPointer(RVA rva) const { 49 const uint8_t* Disassembler::RVAToPointer(RVA rva) const {
50 FileOffset file_offset = RVAToFileOffset(rva); 50 FileOffset file_offset = RVAToFileOffset(rva);
51 if (file_offset == kNoFileOffset) 51 if (file_offset == kNoFileOffset)
52 return nullptr; 52 return nullptr;
53 53
54 return FileOffsetToPointer(file_offset); 54 return FileOffsetToPointer(file_offset);
55 } 55 }
56 56
57 std::unique_ptr<AssemblyProgram> Disassembler::Disassemble() { 57 std::unique_ptr<AssemblyProgram> Disassembler::Disassemble(
58 bool annotate_labels) {
58 if (!ok() || !ExtractAbs32Locations() || !ExtractRel32Locations()) 59 if (!ok() || !ExtractAbs32Locations() || !ExtractRel32Locations())
59 return nullptr; 60 return nullptr;
60 61
61 std::unique_ptr<AssemblyProgram> program = 62 std::unique_ptr<AssemblyProgram> program =
62 base::MakeUnique<AssemblyProgram>(kind(), image_base()); 63 base::MakeUnique<AssemblyProgram>(kind(), image_base());
63 64
64 PrecomputeLabels(program.get()); 65 PrecomputeLabels(program.get());
65 RemoveUnusedRel32Locations(program.get()); 66 RemoveUnusedRel32Locations(program.get());
66 67
67 if (!program->GenerateInstructions(GetInstructionGenerator(program.get()))) 68 if (!program->GenerateInstructions(GetInstructionGenerator(program.get()),
69 annotate_labels)) {
68 return nullptr; 70 return nullptr;
71 }
69 72
70 program->DefaultAssignIndexes(); 73 program->DefaultAssignIndexes();
71 return program; 74 return program;
72 } 75 }
73 76
74 bool Disassembler::Good() { 77 bool Disassembler::Good() {
75 failure_reason_ = nullptr; 78 failure_reason_ = nullptr;
76 return true; 79 return true;
77 } 80 }
78 81
79 bool Disassembler::Bad(const char* reason) { 82 bool Disassembler::Bad(const char* reason) {
80 failure_reason_ = reason; 83 failure_reason_ = reason;
81 return false; 84 return false;
82 } 85 }
83 86
84 void Disassembler::PrecomputeLabels(AssemblyProgram* program) { 87 void Disassembler::PrecomputeLabels(AssemblyProgram* program) {
85 std::unique_ptr<RvaVisitor> abs32_visitor(CreateAbs32TargetRvaVisitor()); 88 std::unique_ptr<RvaVisitor> abs32_visitor(CreateAbs32TargetRvaVisitor());
86 std::unique_ptr<RvaVisitor> rel32_visitor(CreateRel32TargetRvaVisitor()); 89 std::unique_ptr<RvaVisitor> rel32_visitor(CreateRel32TargetRvaVisitor());
87 program->PrecomputeLabels(abs32_visitor.get(), rel32_visitor.get()); 90 program->PrecomputeLabels(abs32_visitor.get(), rel32_visitor.get());
88 } 91 }
89 92
90 void Disassembler::ReduceLength(size_t reduced_length) { 93 void Disassembler::ReduceLength(size_t reduced_length) {
91 CHECK_LE(reduced_length, length_); 94 CHECK_LE(reduced_length, length_);
92 length_ = reduced_length; 95 length_ = reduced_length;
93 end_ = start_ + length_; 96 end_ = start_ + length_;
94 } 97 }
95 98
96 } // namespace courgette 99 } // namespace courgette
OLDNEW
« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32_x86_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698