Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2793133003: [Android] Log gtest stdout regardless of result parsing mode. (Closed)

Created:
3 years, 8 months ago by jbudorick
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Log gtest stdout regardless of result parsing mode. Previously, we only logged gtest stdout as part of parsing the stdout to determine the test results. When using XML parsing (i.e., when a user passed --enable-xml-result-parsing), stdout was not logged. This CL ensures we log the stdout in both cases. BUG=707373 Review-Url: https://codereview.chromium.org/2793133003 Cr-Commit-Position: refs/heads/master@{#461705} Committed: https://chromium.googlesource.com/chromium/src/+/00314619b481948fcaeed5cf5e607232a7e55d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbudorick
3 years, 8 months ago (2017-04-04 02:53:06 UTC) #4
mikecase (-- gone --)
lgtm
3 years, 8 months ago (2017-04-04 05:25:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793133003/1
3 years, 8 months ago (2017-04-04 13:29:49 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 14:20:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00314619b481948fcaeed5cf5e60...

Powered by Google App Engine
This is Rietveld 408576698