ui: Remove SkCanvas methods from drag utils.

ui: Remove SkCanvas methods from drag utils.

This changes MenuController to make a gfx::Canvas backed by a bitmap
without needing to malloc() the gfx::Canvas, then makes a
gfx::ImageSkia to give to the drag utils, avoiding the need for
canvas-specific methods.

Because MenuController makes a bitmap-backed gfx::Canvas it knows that
it can call GetBitmap() to pull the bitmap out, and we remove a call
to gfx::Canvas::ExtractImageRep().

R=pkasting@chromium.org,sadrul@chromium.org
BUG=671433
Review-Url: https://codereview.chromium.org/2793133002
Cr-Commit-Position: refs/heads/master@{#461732}
Committed: https://chromium.googlesource.com/chromium/src/+/c374eccb2b3eaafa9a0cd601e66add1556ed99a8

[danakj, 2017-04-03 19:01:38]

danakj@chromium.org changed reviewers:
- pkasting@chromium.org

[danakj, 2017-04-03 19:01:38]

Looks like sadrul owns all this, moving pkasting to cc (review welcome ofc).

[danakj, 2017-04-03 19:19:17]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:20:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:55:35]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-04-04 04:09:03]

lgtm

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.cc:1250: gfx::Canvas canvas(item->size(),
raster_scale, false);
false /* is_opaque */

[sadrul, 2017-04-04 04:14:08]

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.cc:1256:
drag_utils::SetDragImageOnDataObject(std::move(image),
Oh btw: SetDragImageOnDataObject() takes a const&. Is doing a std::move() here
OK?

Also, I assume this std::move() here does a copy, since gfx::ImageSkia does not
have a move ctor/assign op?

[danakj, 2017-04-04 14:46:17]

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.cc:1250: gfx::Canvas canvas(item->size(),
raster_scale, false);
On 2017/04/04 04:09:03, sadrul wrote:
> false /* is_opaque */

Done.

https://codereview.chromium.org/2793133002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.cc:1256:
drag_utils::SetDragImageOnDataObject(std::move(image),
On 2017/04/04 04:14:08, sadrul wrote:
> Oh btw: SetDragImageOnDataObject() takes a const&. Is doing a std::move() here
> OK?
> 
> Also, I assume this std::move() here does a copy, since gfx::ImageSkia does
not
> have a move ctor/assign op?

move is just a static_cast to a gfx::ImageSkia&&. If the method takes a const&
it would still bind to that. const& can bind to an rvalue or an lvalue. That's
why SetDragImageOnDataObject(MakesAnRvalue()) would work. I guess there's no
point tho, I wanted to say I'm giving up ownership of the bitmap but yeh.

[danakj, 2017-04-04 14:46:30]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-04-04 14:46:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2793133002/#ps20001
(title: "dragutils: .")

[commit-bot: I haz the power, 2017-04-04 14:46:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 15:48:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491317190041620,
"parent_rev": "e1bc254c581e0fab52e1a3772cd1d21bd373e38e", "commit_rev":
"c374eccb2b3eaafa9a0cd601e66add1556ed99a8"}

[commit-bot: I haz the power, 2017-04-04 15:49:35]

Description was changed from

==========
ui: Remove SkCanvas methods from drag utils.

This changes MenuController to make a gfx::Canvas backed by a bitmap
without needing to malloc() the gfx::Canvas, then makes a
gfx::ImageSkia to give to the drag utils, avoiding the need for
canvas-specific methods.

Because MenuController makes a bitmap-backed gfx::Canvas it knows that
it can call GetBitmap() to pull the bitmap out, and we remove a call
to gfx::Canvas::ExtractImageRep().

R=pkasting@chromium.org,sadrul@chromium.org
BUG=671433
==========

to

==========
ui: Remove SkCanvas methods from drag utils.

This changes MenuController to make a gfx::Canvas backed by a bitmap
without needing to malloc() the gfx::Canvas, then makes a
gfx::ImageSkia to give to the drag utils, avoiding the need for
canvas-specific methods.

Because MenuController makes a bitmap-backed gfx::Canvas it knows that
it can call GetBitmap() to pull the bitmap out, and we remove a call
to gfx::Canvas::ExtractImageRep().

R=pkasting@chromium.org,sadrul@chromium.org
BUG=671433

Review-Url: https://codereview.chromium.org/2793133002
Cr-Commit-Position: refs/heads/master@{#461732}
Committed:
https://chromium.googlesource.com/chromium/src/+/c374eccb2b3eaafa9a0cd601e66a...
==========

[commit-bot: I haz the power, 2017-04-04 15:49:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c374eccb2b3eaafa9a0cd601e66a...