Enable float audio output on L+ Android devices.

Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

Benchmarks show it's power neutral, but since it will have objective
improvements in some cases (see bug), lets land it.


BUG=659641
TEST=L+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2793123003
Cr-Commit-Position: refs/heads/master@{#463822}
Committed: https://chromium.googlesource.com/chromium/src/+/4f5539045e3c3eea9197ff328302d8dac89a6711

[DaleCurtis, 2017-04-04 00:14:43]

Description was changed from

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

BUG=none
TEST=N+ device with Lollipop sounds correct.
==========

to

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

BUG=none
TEST=N+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[DaleCurtis, 2017-04-06 19:23:07]

Description was changed from

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

BUG=none
TEST=N+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

Benchmarks show it's power neutral, but since it will have objective
improvements in some cases (see bug), lets land it.


BUG=659641
TEST=L+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[DaleCurtis, 2017-04-06 19:23:07]

dalecurtis@chromium.org changed reviewers:
+ mlamouri@chromium.org

[DaleCurtis, 2017-04-06 19:24:30]

=>mlamouri for review since I'm not sure how we're supposed to enable NDK > 16
features (the one we build Chrome with). Here I've just copied the struct and
constants from the NDK == 21 headers and am luckily able to use the same APIs.
Is there a more preferred way of doing this Mounir?

[Primiano Tucci (use gerrit), 2017-04-07 14:10:07]

On 2017/04/06 19:24:30, DaleCurtis wrote:
> =>mlamouri for review since I'm not sure how we're supposed to enable NDK > 16
> features 
NDK > 16 is going to be quite hard given that the most recent version of the NDK
is r14b, we are currently on r12b:)
https://developer.android.com/ndk/downloads/index.html

I guess what you are after is the actual API level, so you really mean
_android_api_level > 16. 
Right now we target _android_api_level = 16 for 32 bit arch and
_android_api_level=21 for 64 bit arch.
https://cs.chromium.org/chromium/src/build/config/android/config.gni?rcl=42cd...

I think that the _android_api_level is tied to the min_sdk we support (16).
I think we can only bump that once we officially deprecate JB. The next one, KK,
would be min_sdk 19.



> Here I've just copied the struct and
> constants from the NDK == 21 headers and am luckily able to use the same APIs.
> Is there a more preferred way of doing this Mounir?

Until then, if we bump the api level, there is the risk that we end up depending
on libc symbols that are not there on old devices, causing epic crashes because
of linker errors.
So I think that you have to live with a

#if __ANDROID_API__ <= 16
#define SL_AN....
....

like we do elsewhere
https://cs.chromium.org/search/?q=__ANDROID_API__+package:%5Echromium$&type=cs

[mlamouri (slow - plz ping), 2017-04-07 15:02:21]

Dale, hopefully my Primiano's incantation helped :) let me know if you want me
to look at this again

[DaleCurtis, 2017-04-10 21:15:52]

On 2017/04/07 at 14:10:07, primiano wrote:
> On 2017/04/06 19:24:30, DaleCurtis wrote:
> > =>mlamouri for review since I'm not sure how we're supposed to enable NDK >
16
> > features 
> NDK > 16 is going to be quite hard given that the most recent version of the
NDK is r14b, we are currently on r12b:)
> https://developer.android.com/ndk/downloads/index.html

Hah, thanks, yes I did mean API level :)

> 
> I guess what you are after is the actual API level, so you really mean
_android_api_level > 16. 
> Right now we target _android_api_level = 16 for 32 bit arch and
_android_api_level=21 for 64 bit arch.
>
https://cs.chromium.org/chromium/src/build/config/android/config.gni?rcl=42cd...
> 
> I think that the _android_api_level is tied to the min_sdk we support (16).
> I think we can only bump that once we officially deprecate JB. The next one,
KK, would be min_sdk 19.
> 
> 
> 
> > Here I've just copied the struct and
> > constants from the NDK == 21 headers and am luckily able to use the same
APIs.
> > Is there a more preferred way of doing this Mounir?
> 
> Until then, if we bump the api level, there is the risk that we end up
depending on libc symbols that are not there on old devices, causing epic
crashes because of linker errors.
> So I think that you have to live with a
> 
> #if __ANDROID_API__ <= 16
> #define SL_AN....
> ....
> 
> like we do elsewhere
> https://cs.chromium.org/search/?q=__ANDROID_API__+package:%5Echromium$&type=cs

Thanks this is what I needed!

[DaleCurtis, 2017-04-10 21:17:00]

dalecurtis@chromium.org changed reviewers:
+ chcunningham@chromium.org

[DaleCurtis, 2017-04-10 21:17:01]

+chcunningham for media/audio review since the incantation is now Android OWNERS
approved :)

[DaleCurtis, 2017-04-11 19:23:04]

dalecurtis@chromium.org changed reviewers:
+ tguilbert@chromium.org
- chcunningham@chromium.org

[DaleCurtis, 2017-04-11 19:23:04]

Whoops, forgot Chris is ooo, +tguilbert

[tguilbert, 2017-04-11 21:24:32]

LGTM!

[DaleCurtis, 2017-04-11 21:55:24]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-04-11 21:55:25]

Thanks for review!

[commit-bot: I haz the power, 2017-04-11 21:56:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:08:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491947724781060,
"parent_rev": "48e4f10eb4784c4cf1bd09efde38a86457faece2", "commit_rev":
"4f5539045e3c3eea9197ff328302d8dac89a6711"}

[commit-bot: I haz the power, 2017-04-11 23:09:23]

Description was changed from

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

Benchmarks show it's power neutral, but since it will have objective
improvements in some cases (see bug), lets land it.


BUG=659641
TEST=L+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable float audio output on L+ Android devices.

We still need an interleaving step since there doesn't seem to be
planar output, but this avoids the float => s16 conversion.

Benchmarks show it's power neutral, but since it will have objective
improvements in some cases (see bug), lets land it.


BUG=659641
TEST=L+ device with Lollipop sounds correct.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2793123003
Cr-Commit-Position: refs/heads/master@{#463822}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f5539045e3c3eea9197ff328302...
==========

[commit-bot: I haz the power, 2017-04-11 23:09:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f5539045e3c3eea9197ff328302...