Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2793093003:
Remove #include of ptr_util.h in proxy_policy_handler.cc (Closed)
|
Created:
3 years, 8 months ago by vabr (Chromium) Modified:
3 years, 8 months ago Reviewers:
bartfab (slow) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove #include of ptr_util.h in proxy_policy_handler.cc
After recent changes, proxy_policy_handler.cc no longer needs to include
base/memory/ptr_util.h. This has been pointed in
https://codereview.chromium.org/2785883003/diff/80001/components/policy/core/browser/proxy_policy_handler.cc#newcode11.
Because that comment happened after landing of the original CL, that follow-up
is done here.
R=bartfab@chromium.org
BUG=697817
Review-Url: https://codereview.chromium.org/2793093003
Cr-Commit-Position: refs/heads/master@{#466911}
Committed: https://chromium.googlesource.com/chromium/src/+/967cb822e5eb8f4dc2245d2369f12a8f18a66b0e
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi bartfab@, This is a follow up to your recent comment. Please have a look. Cheers, Vaclav
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi bartfab@, A friendly ping: this is addressing you comment from another CL. Thanks! Vaclav
lgtm
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493102806660470, "parent_rev":
"0c9c589259849ee69875a9d173a98f5fb2c0fde6", "commit_rev":
"967cb822e5eb8f4dc2245d2369f12a8f18a66b0e"}
Message was sent while issue was closed.
Description was changed from ========== Remove #include of ptr_util.h in proxy_policy_handler.cc After recent changes, proxy_policy_handler.cc no longer needs to include base/memory/ptr_util.h. This has been pointed in https://codereview.chromium.org/2785883003/diff/80001/components/policy/core/.... Because that comment happened after landing of the original CL, that follow-up is done here. R=bartfab@chromium.org BUG=697817 ========== to ========== Remove #include of ptr_util.h in proxy_policy_handler.cc After recent changes, proxy_policy_handler.cc no longer needs to include base/memory/ptr_util.h. This has been pointed in https://codereview.chromium.org/2785883003/diff/80001/components/policy/core/.... Because that comment happened after landing of the original CL, that follow-up is done here. R=bartfab@chromium.org BUG=697817 Review-Url: https://codereview.chromium.org/2793093003 Cr-Commit-Position: refs/heads/master@{#466911} Committed: https://chromium.googlesource.com/chromium/src/+/967cb822e5eb8f4dc2245d2369f1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/967cb822e5eb8f4dc2245d2369f1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
