Added unit tests for auto_scan_manager. Created switch access test target.

Added unit tests for auto_scan_manager. Created switch access test target.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2793073002
Cr-Commit-Position: refs/heads/master@{#463722}
Committed: https://chromium.googlesource.com/chromium/src/+/ff1db7c1c9c779539bc94f749856926b313edfcb

[elichtenberg, 2017-04-03 17:28:04]

Description was changed from

==========
Added some unit tests. Trying to turn auto_scan_manager_unittest into webui
test, but having a dependency issue.

BUG=593885
==========

to

==========
Added some unit tests. Trying to turn auto_scan_manager_unittest into webui
test, but having a dependency issue.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-04-03 17:29:28]

Description was changed from

==========
Added some unit tests. Trying to turn auto_scan_manager_unittest into webui
test, but having a dependency issue.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added some unit tests. Trying to turn auto_scan_manager_unittest into webui
test, but having a dependency issue.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-04-03 17:32:10]

elichtenberg@google.com changed reviewers:
+ dmazzoni@chromium.org

[elichtenberg, 2017-04-05 22:00:30]

Description was changed from

==========
Added some unit tests. Trying to turn auto_scan_manager_unittest into webui
test, but having a dependency issue.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added unit tests for auto_scan_manager. Created switch access test target.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-04-05 22:00:59]

elichtenberg@google.com changed reviewers:
+ dtseng@chromium.org

[elichtenberg, 2017-04-05 22:01:15]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:01:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:39:27]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-07 15:54:34]

lgtm

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs
(right):

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs:13:
return 1;
Does this set the time delay to 1 for tests?

I'd prefer you make it more explicit, maybe by actually
checking the key, or else add a comment to explain the
effect that this has. I didn't figure it out until I
got further down the file and was wondering how you could
be sure that the scan would finish in 10 ms.

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs:63:
return window.realSetInterval(func, delay);
Would it work to set the "real" delay to something short like 1ms
to make the test run faster?

[elichtenberg, 2017-04-07 23:06:30]

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs
(right):

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs:13:
return 1;
On 2017/04/07 15:54:34, dmazzoni wrote:
> Does this set the time delay to 1 for tests?
> 
> I'd prefer you make it more explicit, maybe by actually
> checking the key, or else add a comment to explain the
> effect that this has. I didn't figure it out until I
> got further down the file and was wondering how you could
> be sure that the scan would finish in 10 ms.

Good point, sorry I didn't make it clear earlier. Is the change I made what you
meant by checking the key?

https://codereview.chromium.org/2793073002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs:63:
return window.realSetInterval(func, delay);
On 2017/04/07 15:54:34, dmazzoni wrote:
> Would it work to set the "real" delay to something short like 1ms
> to make the test run faster?

Yes that would work. I'm just testing that autoScanManager passes the correct
delay time to setInterval, so it doesn't matter what setInterval does with it.

[elichtenberg, 2017-04-07 23:07:08]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 23:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 00:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 00:14:00]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-11 02:53:54]

still lgtm, thanks

[elichtenberg, 2017-04-11 16:29:07]

The CQ bit was checked by elichtenberg@google.com

[commit-bot: I haz the power, 2017-04-11 16:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:26:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491928147398590,
"parent_rev": "fdc247eba3186d7c33195fda3a51021919d2e90a", "commit_rev":
"ff1db7c1c9c779539bc94f749856926b313edfcb"}

[commit-bot: I haz the power, 2017-04-11 19:27:51]

Description was changed from

==========
Added unit tests for auto_scan_manager. Created switch access test target.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added unit tests for auto_scan_manager. Created switch access test target.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2793073002
Cr-Commit-Position: refs/heads/master@{#463722}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff1db7c1c9c779539bc94f749856...
==========

[commit-bot: I haz the power, 2017-04-11 19:27:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff1db7c1c9c779539bc94f749856...