Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2793033003: [Android] Remove org.apache.http from proguard flags and gn. (Closed)

Created:
3 years, 8 months ago by jbudorick
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, cbentzel+watch_chromium.org, jam, net-reviews_chromium.org, darin-cc_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove org.apache.http from proguard flags and gn. BUG=468861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2793033003 Cr-Commit-Position: refs/heads/master@{#462056} Committed: https://chromium.googlesource.com/chromium/src/+/a18c3d5b04f0c161502f6f88f788b5612ba44ce1

Patch Set 1 #

Patch Set 2 : shenghuazhang comment #

Patch Set 3 : rebase and git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -41 lines) Patch
M android_webview/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/test/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/cronet/android/sample/javatests/proguard.cfg View 1 chunk +0 lines, -3 lines 0 comments Download
M components/cronet/android/test/proguard.cfg View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/proguard_for_test.flags View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 33 (20 generated)
jbudorick
3 years, 8 months ago (2017-04-03 19:23:42 UTC) #5
shenghuazhang
lgtm I think this line could also be removed? https://codesearch.chromium.org/chromium/src/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java?q=488192&dr=C&l=39
3 years, 8 months ago (2017-04-03 21:27:58 UTC) #8
jbudorick
On 2017/04/03 21:27:58, shenghuazhang wrote: > lgtm > > I think this line could also ...
3 years, 8 months ago (2017-04-04 00:46:04 UTC) #9
Yaron
lgtm \o/
3 years, 8 months ago (2017-04-04 17:33:51 UTC) #14
jbudorick
+boliu for //android_webview +xunjieli for //components/cronet and //net
3 years, 8 months ago (2017-04-04 19:01:45 UTC) #16
xunjieli
> +xunjieli for //components/cronet and //net lgtm. great to see this getting removed!
3 years, 8 months ago (2017-04-04 19:27:32 UTC) #17
boliu
lgtm woot \o/
3 years, 8 months ago (2017-04-04 20:01:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793033003/20001
3 years, 8 months ago (2017-04-04 20:08:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/402255)
3 years, 8 months ago (2017-04-04 20:21:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793033003/40001
3 years, 8 months ago (2017-04-04 22:15:31 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264570)
3 years, 8 months ago (2017-04-05 01:34:04 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793033003/40001
3 years, 8 months ago (2017-04-05 13:05:04 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 13:55:30 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a18c3d5b04f0c161502f6f88f788...

Powered by Google App Engine
This is Rietveld 408576698