Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2793003003: Move ScriptState::forWorld/ScriptState::forMainWorld (Part 3) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::forWorld/ScriptState::forMainWorld (Part 3) This CL removes ScriptState::forWorld and ScriptState::forMainWorld. BUG=682322 Review-Url: https://codereview.chromium.org/2793003003 Cr-Commit-Position: refs/heads/master@{#462183} Committed: https://chromium.googlesource.com/chromium/src/+/9576d4b6be1d462eef802578c9ecde7b32470285

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
adithyas
3 years, 8 months ago (2017-04-05 14:30:55 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-04-05 14:31:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793003003/20001
3 years, 8 months ago (2017-04-05 19:30:00 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 19:41:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9576d4b6be1d462eef802578c9ec...

Powered by Google App Engine
This is Rietveld 408576698