Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2792913003:
Add new official.desktop Win PGO recipe builder. (Closed)
|
Created:
3 years, 8 months ago by Michael Moss Modified:
3 years, 8 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd new official.desktop Win PGO recipe builder.
BUG=418185
TBR=dimu@google.com, dpranke@google.com
Review-Url: https://codereview.chromium.org/2792913003
Cr-Commit-Position: refs/heads/master@{#461579}
Committed: https://chromium.googlesource.com/chromium/src/+/4185f5ffb15db14f5e69181344870629c8b4dc58
Patch Set 1 #
Total comments: 1
Patch Set 2 : add TODO #Messages
Total messages: 19 (10 generated)
lgtm https://codereview.chromium.org/2792913003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2792913003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:456: 'win64-pgo-recipes': { TODO that we will delete it after verifying the recipes pinning changes?
The CQ bit was checked by mmoss@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add new official.desktop Win PGO recipe builder. BUG=418185 R=dimu@google.com, dpranke@google.com ========== to ========== Add new official.desktop Win PGO recipe builder. BUG=418185 TBR=dimu@google.com, dpranke@google.com ==========
The CQ bit was checked by mmoss@chromium.org
The CQ bit was unchecked by mmoss@chromium.org
The CQ bit was checked by mmoss@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dimu@google.com Link to the patchset: https://codereview.chromium.org/2792913003/#ps20001 (title: "add TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
I'm a bit confused by this CL. win-pgo is already on recipes, so what is this CL doing?
On 2017/04/03 21:44:37, Dirk Pranke wrote: > I'm a bit confused by this CL. win-pgo is already on recipes, so what is this CL > doing? The existing PGO recipes are a bit hacked together and pgo-specific. This is testing PGO builds on the new, standardized official recipes.
On 2017/04/03 21:52:13, Michael Moss wrote: > On 2017/04/03 21:44:37, Dirk Pranke wrote: > > I'm a bit confused by this CL. win-pgo is already on recipes, so what is this > CL > > doing? > > The existing PGO recipes are a bit hacked together and pgo-specific. This is > testing PGO builds on the new, standardized official recipes. I see. I'd like to review the new recipes and/or how the PGO builds will change as a part of that at some point, then. lgtm otherwise.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491252988167790,
"parent_rev": "b50b92561ef8705d31479d018cf59d83206a0ccc", "commit_rev":
"4185f5ffb15db14f5e69181344870629c8b4dc58"}
Message was sent while issue was closed.
Description was changed from ========== Add new official.desktop Win PGO recipe builder. BUG=418185 TBR=dimu@google.com, dpranke@google.com ========== to ========== Add new official.desktop Win PGO recipe builder. BUG=418185 TBR=dimu@google.com, dpranke@google.com Review-Url: https://codereview.chromium.org/2792913003 Cr-Commit-Position: refs/heads/master@{#461579} Committed: https://chromium.googlesource.com/chromium/src/+/4185f5ffb15db14f5e6918134487... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4185f5ffb15db14f5e6918134487... |
