Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2792833002: Revert of Optimize the pre-paint tree walk and ClipRects (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
pdr., Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize the pre-paint tree walk and ClipRects (patchset #3 id:40001 of https://codereview.chromium.org/2784963002/ ) Reason for revert: On further investigation, found that this patch introduces too much inefficiency by making all PaintLayers pay the cost of a ClipRects object, rather than just ones that induce subsequences. Original issue's description: > Optimize the pre-paint tree walk and ClipRects. > > 1. Avoid malloc for ClipRects objects. This trades reduced malloc for > a somewhat larger PaintLayer. > 2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper > now checks for transforms on infininte rects instead). > 3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. > > Local runs showed pre-paint time improvements in about:tracing for > Paint/containment-resize.html of up to 5%. > > I am also running a CT analysis with and without SPInvalidation on to see effect > on paint times. Early data suggests no strong change either way. (though note that > this CL is mainly aimed at reducing time in pre-paint). > > BUG=692614 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2784963002 > Cr-Commit-Position: refs/heads/master@{#460808} > Committed: https://chromium.googlesource.com/chromium/src/+/65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20 TBR=pdr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=692614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -65 lines) Patch
A third_party/WebKit/Source/core/layout/ClipRects.h View 1 chunk +101 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipRects.h View 2 chunks +19 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipRectsCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +6 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 4 chunks +39 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chrishtr
Created Revert of Optimize the pre-paint tree walk and ClipRects
3 years, 8 months ago (2017-04-02 17:02:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792833002/1
3 years, 8 months ago (2017-04-02 17:02:48 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-02 18:36:39 UTC) #6
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698