Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2792823002: [ios] Unittest for TabGridMediator. (Closed)

Created:
3 years, 8 months ago by edchin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Unittest for TabGridMediator. BUG=none Review-Url: https://codereview.chromium.org/2792823002 Cr-Commit-Position: refs/heads/master@{#462882} Committed: https://chromium.googlesource.com/chromium/src/+/e83dfc3e1bae851d9701cba5e2399be919cf75df

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M ios/clean/chrome/browser/ui/tab_grid/BUILD.gn View 1 1 chunk +23 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator.mm View 1 chunk +1 line, -3 lines 0 comments Download
A ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm View 1 1 chunk +74 lines, -0 lines 0 comments Download
M ios/clean/chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
edchin
3 years, 8 months ago (2017-04-03 03:05:24 UTC) #14
lpromero
lgtm https://codereview.chromium.org/2792823002/diff/1/ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm File ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm (right): https://codereview.chromium.org/2792823002/diff/1/ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm#newcode33 ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm:33: mediator_.consumer = nil; There is something unbalanced with ...
3 years, 8 months ago (2017-04-03 09:25:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792823002/20001
3 years, 8 months ago (2017-04-07 06:16:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792823002/40001
3 years, 8 months ago (2017-04-07 14:59:37 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 16:17:41 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e83dfc3e1bae851d9701cba5e239...

Powered by Google App Engine
This is Rietveld 408576698