Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2792773002: Fullscreen backdrop window for maximize mode (Closed)

Created:
3 years, 8 months ago by oshima
Modified:
3 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fullscreen backdrop window for maximize mode Regular window size is capped to be smaller than workarea. BUG=705577, 706881 TEST=manual Review-Url: https://codereview.chromium.org/2792773002 Cr-Commit-Position: refs/heads/master@{#461379} Committed: https://chromium.googlesource.com/chromium/src/+/f97f2a165d8806024a90c8ee3a9b68ee0a4d06da

Patch Set 1 : . #

Patch Set 2 : updated the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -70 lines) Patch
M ash/common/wm/maximize_mode/workspace_backdrop_delegate.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc View 5 chunks +2 lines, -46 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_backdrop_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_unittest.cc View 1 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
oshima
3 years, 8 months ago (2017-04-01 16:55:33 UTC) #9
Mr4D (OOO till 08-26)
Ah - this explains some shelf issues I have seen. lgtm!
3 years, 8 months ago (2017-04-02 20:03:13 UTC) #13
Mr4D (OOO till 08-26)
Ah - this explains some shelf issues I have seen. lgtm!
3 years, 8 months ago (2017-04-02 20:03:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792773002/60001
3 years, 8 months ago (2017-04-03 06:30:54 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 07:08:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f97f2a165d8806024a90c8ee3a9b...

Powered by Google App Engine
This is Rietveld 408576698