Display: dectect changes to mirror mode and send a notification.

Display: dectect changes to mirror mode and send a notification.

Currently if an external display is removed exiting mirror mode,
not DisplayObserver notification is sent.

This CL adds a DisplayMetric bit and sets it whenever the mirror
mode changes.

BUG=707328
Review-Url: https://codereview.chromium.org/2792733002
Cr-Commit-Position: refs/heads/master@{#461810}
Committed: https://chromium.googlesource.com/chromium/src/+/0c150c2f05a1bc1e46f8bbace6228d365d4d50d2

[stevenjb, 2017-04-01 00:38:01]

stevenjb@chromium.org changed reviewers:
+ oshima@chromium.org

[stevenjb, 2017-04-01 00:38:02]

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
File ui/display/manager/display_manager.h (right):

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
ui/display/manager/display_manager.h:475: bool mirror_mode_for_metrics_ = false;
I tried to avoid the need for this, but the code paths for setting
mirroring_display_id_ (which is how we identify mirror mode) is.... complicated,
and I was nervous about changing it.

[oshima, 2017-04-03 19:38:17]

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
File ui/display/manager/display_manager.h (right):

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
ui/display/manager/display_manager.h:475: bool mirror_mode_for_metrics_ = false;
On 2017/04/01 00:38:02, stevenjb wrote:
> I tried to avoid the need for this, but the code paths for setting
> mirroring_display_id_ (which is how we identify mirror mode) is....
complicated,
> and I was nervous about changing it.

Can't you check before and after like

boolean wasInMirror = IsInMirrorMode();

update goes on


boolean isInMirror = IsInMirrorMode();

if (wasInMirro != isInMirror) {
}
?

[stevenjb, 2017-04-03 19:49:50]

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
File ui/display/manager/display_manager.h (right):

https://codereview.chromium.org/2792733002/diff/1/ui/display/manager/display_...
ui/display/manager/display_manager.h:475: bool mirror_mode_for_metrics_ = false;
On 2017/04/03 19:38:17, oshima wrote:
> On 2017/04/01 00:38:02, stevenjb wrote:
> > I tried to avoid the need for this, but the code paths for setting
> > mirroring_display_id_ (which is how we identify mirror mode) is....
> complicated,
> > and I was nervous about changing it.
> 
> Can't you check before and after like
> 
> boolean wasInMirror = IsInMirrorMode();
> 
> update goes on
> 
> 
> boolean isInMirror = IsInMirrorMode();
> 
> if (wasInMirro != isInMirror) {
> }
> ?

Nope. mirroring_display_id_ (which is what IsInMirrorMode() checks) gets set
before UpdateDisplaysWith() is called. UpdateDisplaysWith() gets called from 10
call sites, and mirroring_display_id_ gets set in 5 different places, so
tracking down where/when/why it gets set is beyond me. I'd be happy to review a
change that cleans all that up though :)

[oshima, 2017-04-03 22:31:51]

lgtm

let me take a look at it but let's land this as you need this to work on UI.

[stevenjb, 2017-04-03 22:47:21]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:48:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 23:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 23:36:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-04-04 18:10:32]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-04 18:10:33]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2792733002/#ps20001
(title: "Fix test")

[commit-bot: I haz the power, 2017-04-04 18:11:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 20:13:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491329432616420,
"parent_rev": "aac263065fb2cb1356fceccf844ed2e08fe6da9a", "commit_rev":
"0c150c2f05a1bc1e46f8bbace6228d365d4d50d2"}

[commit-bot: I haz the power, 2017-04-04 20:15:03]

Description was changed from

==========
Display: dectect changes to mirror mode and send a notification.

Currently if an external display is removed exiting mirror mode,
not DisplayObserver notification is sent.

This CL adds a DisplayMetric bit and sets it whenever the mirror
mode changes.

BUG=707328
==========

to

==========
Display: dectect changes to mirror mode and send a notification.

Currently if an external display is removed exiting mirror mode,
not DisplayObserver notification is sent.

This CL adds a DisplayMetric bit and sets it whenever the mirror
mode changes.

BUG=707328

Review-Url: https://codereview.chromium.org/2792733002
Cr-Commit-Position: refs/heads/master@{#461810}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c150c2f05a1bc1e46f8bbace622...
==========

[commit-bot: I haz the power, 2017-04-04 20:15:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c150c2f05a1bc1e46f8bbace622...