Move ConnectionToHost parameters out from Connect() call.

Move ConnectionToHost parameters out from Connect() call.

Connect() has ended up acquiring all of the ConnectionToHost's
configuration settings as parameters, making calling code harder to read
especially as more new parameters are added.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272074

[Wez, 2014-05-13 13:05:38]

PTAL

[Wez, 2014-05-20 20:25:00]

On 2014/05/13 13:05:38, Wez wrote:
> PTAL

Ping.

[Sergey Ulanov, 2014-05-21 03:42:33]

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
File remoting/protocol/connection_to_host.h (right):

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:108: // Set the stubs which will handle
messages from the host.
nit: put this above Connect(), because they are normally called before
Connect().

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:112: virtual void
set_client_stub(ClientStub* client_stub);
Do these need to be virtual? 
Can they be inlined?

[Sergey Ulanov, 2014-05-21 03:42:40]

lgtm

[Wez, 2014-05-21 05:14:21]

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
File remoting/protocol/connection_to_host.h (right):

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:108: // Set the stubs which will handle
messages from the host.
On 2014/05/21 03:42:33, Sergey Ulanov wrote:
> nit: put this above Connect(), because they are normally called before
> Connect().

Done.

https://codereview.chromium.org/279273002/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:112: virtual void
set_client_stub(ClientStub* client_stub);
On 2014/05/21 03:42:33, Sergey Ulanov wrote:
> Do these need to be virtual?

Nope. Fixed.

> Can they be inlined?

set_video_stub() has a non-trivial impl, so I'd prefer to keep them all in the
cc.

[Wez, 2014-05-21 17:35:42]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:58:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/279273002/20001

[commit-bot: I haz the power, 2014-05-22 03:39:48]

Change committed as 272074