Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: remoting/protocol/connection_to_host.cc

Issue 279273002: Move ConnectionToHost parameters out from Connect() call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/connection_to_host.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/connection_to_host.cc
diff --git a/remoting/protocol/connection_to_host.cc b/remoting/protocol/connection_to_host.cc
index d2ce7ff3112e38ca2ac0af19ca3b04041a399475..d09eaa1e697690ed560c69900ea1e219bc749032 100644
--- a/remoting/protocol/connection_to_host.cc
+++ b/remoting/protocol/connection_to_host.cc
@@ -51,40 +51,18 @@ ConnectionToHost::~ConnectionToHost() {
signal_strategy_->RemoveListener(this);
}
-ClipboardStub* ConnectionToHost::clipboard_stub() {
- return &clipboard_forwarder_;
-}
-
-HostStub* ConnectionToHost::host_stub() {
- // TODO(wez): Add a HostFilter class, equivalent to input filter.
- return control_dispatcher_.get();
-}
-
-InputStub* ConnectionToHost::input_stub() {
- return &event_forwarder_;
-}
-
void ConnectionToHost::Connect(SignalStrategy* signal_strategy,
- const std::string& host_jid,
- const std::string& host_public_key,
scoped_ptr<TransportFactory> transport_factory,
scoped_ptr<Authenticator> authenticator,
- HostEventCallback* event_callback,
- ClientStub* client_stub,
- ClipboardStub* clipboard_stub,
- VideoStub* video_stub,
- AudioStub* audio_stub) {
+ const std::string& host_jid,
+ const std::string& host_public_key,
+ HostEventCallback* event_callback) {
+ DCHECK(client_stub_);
+ DCHECK(clipboard_stub_);
+ DCHECK(monitored_video_stub_);
+
signal_strategy_ = signal_strategy;
event_callback_ = event_callback;
- client_stub_ = client_stub;
- clipboard_stub_ = clipboard_stub;
- monitored_video_stub_.reset(new MonitoredVideoStub(
- video_stub,
- base::TimeDelta::FromSeconds(
- MonitoredVideoStub::kConnectivityCheckDelaySeconds),
- base::Bind(&ConnectionToHost::OnVideoChannelStatus,
- base::Unretained(this))));
- audio_stub_ = audio_stub;
authenticator_ = authenticator.Pass();
// Save jid of the host. The actual connection is created later after
@@ -105,6 +83,41 @@ const SessionConfig& ConnectionToHost::config() {
return session_->config();
}
+ClipboardStub* ConnectionToHost::clipboard_forwarder() {
+ return &clipboard_forwarder_;
+}
+
+HostStub* ConnectionToHost::host_stub() {
+ // TODO(wez): Add a HostFilter class, equivalent to input filter.
+ return control_dispatcher_.get();
+}
+
+InputStub* ConnectionToHost::input_stub() {
+ return &event_forwarder_;
+}
+
+void ConnectionToHost::set_client_stub(ClientStub* client_stub) {
+ client_stub_ = client_stub;
+}
+
+void ConnectionToHost::set_clipboard_stub(ClipboardStub* clipboard_stub) {
+ clipboard_stub_ = clipboard_stub;
+}
+
+void ConnectionToHost::set_video_stub(VideoStub* video_stub) {
+ DCHECK(video_stub);
+ monitored_video_stub_.reset(new MonitoredVideoStub(
+ video_stub,
+ base::TimeDelta::FromSeconds(
+ MonitoredVideoStub::kConnectivityCheckDelaySeconds),
+ base::Bind(&ConnectionToHost::OnVideoChannelStatus,
+ base::Unretained(this))));
+}
+
+void ConnectionToHost::set_audio_stub(AudioStub* audio_stub) {
+ audio_stub_ = audio_stub;
+}
+
void ConnectionToHost::OnSignalStrategyStateChange(
SignalStrategy::State state) {
DCHECK(CalledOnValidThread());
« no previous file with comments | « remoting/protocol/connection_to_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698