Remove pretty_print step from histograms presubmit, git cl format handles this.

Remove pretty_print step from histograms presubmit, git cl format handles this.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none

Review-Url: https://codereview.chromium.org/2792723002
Cr-Commit-Position: refs/heads/master@{#461496}
Committed: https://chromium.googlesource.com/chromium/src/+/94124abb3ca82523119708171401921ba1c3c779

[DaleCurtis, 2017-04-01 00:35:33]

dalecurtis@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-04-03 15:47:47]

Description was changed from

==========
Remove histograms presubmit, we always run git cl format now.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=none
TEST=none
==========

to

==========
Remove histograms presubmit, we always run git cl format now.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none
==========

[Alexei Svitkine (slow), 2017-04-03 15:49:50]

Thanks! I set BUG=694786 on the CL description.

https://codereview.chromium.org/2792723002/diff/1/tools/metrics/histograms/PR...
File tools/metrics/histograms/PRESUBMIT.py (left):

https://codereview.chromium.org/2792723002/diff/1/tools/metrics/histograms/PR...
tools/metrics/histograms/PRESUBMIT.py:29: 'histograms.xml is not well formatted;
run %s/validate_format.py '
"git cl format" only does the pretty_print.py part - not validate_format.py
(which checks it for semantics).

So I think this part should still remain.

[DaleCurtis, 2017-04-03 18:22:54]

https://codereview.chromium.org/2792723002/diff/1/tools/metrics/histograms/PR...
File tools/metrics/histograms/PRESUBMIT.py (left):

https://codereview.chromium.org/2792723002/diff/1/tools/metrics/histograms/PR...
tools/metrics/histograms/PRESUBMIT.py:29: 'histograms.xml is not well formatted;
run %s/validate_format.py '
On 2017/04/03 at 15:49:49, Alexei Svitkine (slow) wrote:
> "git cl format" only does the pretty_print.py part - not validate_format.py
(which checks it for semantics).
> 
> So I think this part should still remain.

Ah yeah, git cl format has rudimentary validation, but won't catch some of the
histograms specific stuff around enum duplication, etc. It'd be nice if the
validation step could be run on the parsed tree from the formatter (so parsing
isn't done twice), but currently pretty_print_xml is a generic script instead of
specific to histograms.

[DaleCurtis, 2017-04-03 18:23:14]

Description was changed from

==========
Remove histograms presubmit, we always run git cl format now.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none
==========

to

==========
Remove pretty_print step from histograms presubmit, git cl format handles this.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none
==========

[Alexei Svitkine (slow), 2017-04-03 18:28:27]

lgtm, thanks!

[DaleCurtis, 2017-04-03 18:41:29]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-04-03 18:41:30]

np, thanks for review!

[commit-bot: I haz the power, 2017-04-03 18:42:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:06:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491244889971330,
"parent_rev": "a812312f165c373e9f9fb684b229bb5a987e9328", "commit_rev":
"94124abb3ca82523119708171401921ba1c3c779"}

[commit-bot: I haz the power, 2017-04-03 19:07:12]

Description was changed from

==========
Remove pretty_print step from histograms presubmit, git cl format handles this.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none
==========

to

==========
Remove pretty_print step from histograms presubmit, git cl format handles this.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG=694786
TEST=none

Review-Url: https://codereview.chromium.org/2792723002
Cr-Commit-Position: refs/heads/master@{#461496}
Committed:
https://chromium.googlesource.com/chromium/src/+/94124abb3ca82523119708171401...
==========

[commit-bot: I haz the power, 2017-04-03 19:07:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/94124abb3ca82523119708171401...