Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2792673002: Remove effective_manufacturer frome printer policy object. (Closed)

Created:
3 years, 8 months ago by skau
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, Carlson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove effective_manufacturer frome printer policy object. We're removed effective_manufacturer from NativePrinters in favor of using just effective_model with all the included information. We can make the same uniqueness guarantees and simplify string construction and validation. Also update the supported version since support did not actually land in Chrome until M57. BUG=707378, 707376 Review-Url: https://codereview.chromium.org/2792673002 Cr-Commit-Position: refs/heads/master@{#462515} Committed: https://chromium.googlesource.com/chromium/src/+/850ee094029a825aae5b93e366b28195c8345800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M components/policy/resources/policy_templates.json View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
skau
atwilson: Please review this documentation update.
3 years, 8 months ago (2017-03-31 21:17:43 UTC) #2
Andrew T Wilson (Slow)
Bartosz, Sergey FYI
3 years, 8 months ago (2017-04-04 12:57:18 UTC) #8
skau
Ping?
3 years, 8 months ago (2017-04-05 22:44:21 UTC) #9
Andrew T Wilson (Slow)
lgtm
3 years, 8 months ago (2017-04-06 13:15:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792673002/1
3 years, 8 months ago (2017-04-06 15:36:58 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 16:59:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/850ee094029a825aae5b93e366b2...

Powered by Google App Engine
This is Rietveld 408576698