Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: ipc/ipc_message_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/web_view_js_utils.mm ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_unittest.cc
diff --git a/ipc/ipc_message_unittest.cc b/ipc/ipc_message_unittest.cc
index fd08452a14fa0151d56aa4db5eea9d25c934f38c..1bf52d8f9d27584eb64d381cd9470b1070803d2c 100644
--- a/ipc/ipc_message_unittest.cc
+++ b/ipc/ipc_message_unittest.cc
@@ -11,6 +11,7 @@
#include <limits>
#include <memory>
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "build/build_config.h"
@@ -67,7 +68,7 @@ TEST(IPCMessageTest, ListValue) {
base::ListValue input;
input.Set(0, new base::Value(42.42));
input.Set(1, new base::Value("forty"));
- input.Set(2, base::Value::CreateNullValue());
+ input.Set(2, base::MakeUnique<base::Value>());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
@@ -87,7 +88,7 @@ TEST(IPCMessageTest, ListValue) {
TEST(IPCMessageTest, DictionaryValue) {
base::DictionaryValue input;
- input.Set("null", base::Value::CreateNullValue());
+ input.Set("null", base::MakeUnique<base::Value>());
input.Set("bool", new base::Value(true));
input.Set("int", new base::Value(42));
input.SetWithoutPathExpansion("int.with.dot", new base::Value(43));
« no previous file with comments | « ios/web/web_state/ui/web_view_js_utils.mm ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698