Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3703)

Unified Diff: chrome/browser/ui/webui/options/cookies_view_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/options/cookies_view_handler.cc b/chrome/browser/ui/webui/options/cookies_view_handler.cc
index fed3637ffd5fe79fbd6b19778dcd29ed97dd530c..7b1a4bb686fc7700064f4eb448733f591f37a0c7 100644
--- a/chrome/browser/ui/webui/options/cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/options/cookies_view_handler.cc
@@ -10,6 +10,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/browsing_data/browsing_data_appcache_helper.h"
@@ -159,7 +160,7 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
base::ListValue args;
if (parent == tree_model->GetRoot())
- args.Append(base::Value::CreateNullValue());
+ args.Append(base::MakeUnique<base::Value>());
else
args.AppendString(model_util_->GetTreeNodeId(parent_node));
args.AppendInteger(start);
@@ -179,7 +180,7 @@ void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
base::ListValue args;
if (parent == tree_model->GetRoot())
- args.Append(base::Value::CreateNullValue());
+ args.Append(base::MakeUnique<base::Value>());
else
args.AppendString(model_util_->GetTreeNodeId(tree_model->AsNode(parent)));
args.AppendInteger(start);
@@ -279,7 +280,7 @@ void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
base::ListValue args;
if (parent == cookies_tree_model_->GetRoot())
- args.Append(base::Value::CreateNullValue());
+ args.Append(base::MakeUnique<base::Value>());
else
args.AppendString(model_util_->GetTreeNodeId(parent));
args.Append(std::move(children));

Powered by Google App Engine
This is Rietveld 408576698