Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
index eda33f4b0740767b9383ff1de8f80d8c88732bd3..cce634b34b878f725ed1bc70fff8ac46360d8e0a 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
@@ -1195,9 +1195,9 @@ void CertificateManagerHandler::ShowError(const std::string& title,
auto error_value = base::MakeUnique<base::Value>(error);
auto ok_title_value =
base::MakeUnique<base::Value>(l10n_util::GetStringUTF8(IDS_OK));
- auto cancel_title_value = base::Value::CreateNullValue();
- auto ok_callback_value = base::Value::CreateNullValue();
- auto cancel_callback_value = base::Value::CreateNullValue();
+ auto cancel_title_value = base::MakeUnique<base::Value>();
+ auto ok_callback_value = base::MakeUnique<base::Value>();
+ auto cancel_callback_value = base::MakeUnique<base::Value>();
std::vector<const base::Value*> args = {
title_value.get(), error_value.get(),
ok_title_value.get(), cancel_title_value.get(),

Powered by Google App Engine
This is Rietveld 408576698