Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2792563003: Settings: a11y: Just hide 'additional features' link (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
hcarmona, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: a11y: Just hide 'additional features' link In crbug.com/682107 we disabled the entire 'managed a11y features' subpage instead of just the 'additional features' link. (The 'additional features' link goes to the web store which is not available in guest mode). BUG=704046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2792563003 Cr-Commit-Position: refs/heads/master@{#461253} Committed: https://chromium.googlesource.com/chromium/src/+/7e189606bbbf9cf5f81200bca143e1ff3729faf2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +10 lines, -12 lines 1 comment Download
M chrome/browser/resources/settings/a11y_page/a11y_page.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.html View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stevenjb
https://codereview.chromium.org/2792563003/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html File chrome/browser/resources/settings/a11y_page/a11y_page.html (right): https://codereview.chromium.org/2792563003/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html#newcode41 chrome/browser/resources/settings/a11y_page/a11y_page.html:41: </div> One of these days a diff program will ...
3 years, 8 months ago (2017-03-31 17:48:55 UTC) #3
hcarmona
lgtm
3 years, 8 months ago (2017-03-31 21:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792563003/1
3 years, 8 months ago (2017-03-31 21:05:52 UTC) #6
michaelpg
lgtm -- add guest mode to subject/description?
3 years, 8 months ago (2017-03-31 21:37:03 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 22:25:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e189606bbbf9cf5f81200bca143...

Powered by Google App Engine
This is Rietveld 408576698