Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2792523002: [regexp] Fix numbered reference before named capture (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix numbered reference before named capture Numbered back-references that occur before the referenced capture trigger an internal mini-parser that looks ahead in the pattern and counts capturing groups. This updates the mini-parser to correctly handle named captures. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2792523002 Cr-Commit-Position: refs/heads/master@{#44303} Committed: https://chromium.googlesource.com/v8/v8/+/3f8b2aeb3587dad6a279d439db56db785197253a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/regexp/regexp-parser.cc View 1 chunk +19 lines, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 8 months ago (2017-03-31 09:03:13 UTC) #4
Yang
On 2017/03/31 09:03:13, jgruber wrote: lgtm.
3 years, 8 months ago (2017-03-31 10:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792523002/1
3 years, 8 months ago (2017-03-31 10:48:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 10:50:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3f8b2aeb3587dad6a279d439db56db78519...

Powered by Google App Engine
This is Rietveld 408576698