Ship ReadableStream pipeTo()

Ship ReadableStream pipeTo()

This involves removing the hack where out-of-line methods are defined as
internal functions in ReadableStream.js and then exported by
ReadableStreamExperimentalPipeTo.js. Now pipeThrough() and pipeTo() are defined
directly on the ReadableStream object.

ReadableStreamPipeTo() is still implemented as a separate function for
readability.

Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0EW0_vT_MOU/rY-0w8efCwAJ

TBR=brettw@chromium.org
R=tyoshino@chromium.org
CC=domenic@chromium.org
BUG=668951
Review-Url: https://codereview.chromium.org/2792513002
Cr-Commit-Position: refs/heads/master@{#462041}
Committed: https://chromium.googlesource.com/chromium/src/+/3f731a954bb05de9f166e427c507dac861cab0fc

[Adam Rice, 2017-03-31 07:26:19]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 07:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 08:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 08:47:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2017-03-31 11:43:33]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 11:43:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-03-31 12:25:26]

ricea@chromium.org changed reviewers:
- brettw@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:25:48]

Dry run: This issue passed the CQ dry run.

[domenic, 2017-04-03 05:49:29]

domenic@chromium.org changed reviewers:
+ domenic@chromium.org

[domenic, 2017-04-03 05:49:30]

Can we also import the web platform tests/delete our old tests?

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:181: return readable;
Shouldn't this mark the promise as handled?

[Adam Rice, 2017-04-03 15:07:28]

On 2017/04/03 05:49:30, domenic wrote:
> Can we also import the web platform tests/delete our old tests?

This is mostly done. We're already importing and running all the web
platform tests. There are a few more old duplicate tests I want to
clean up once the WritableStream update has landed.

[Adam Rice, 2017-04-03 15:08:15]

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:181: return readable;
On 2017/04/03 05:49:30, domenic wrote:
> Shouldn't this mark the promise as handled?

I want to update the implementation in a separate CL like I'm doing for
WritableStream. I created a CL which implements this change:

https://codereview.chromium.org/2796633002/

[Adam Rice, 2017-04-05 02:49:33]

ricea@chromium.org changed reviewers:
+ foolip@chromium.org

[Adam Rice, 2017-04-05 02:49:34]

+foolip for API_OWNERS.

tyoshino@ and domenic@ are at the ServiceWorker f2f, but can I have an API_OWNER
lgtm in the meantime?

[foolip, 2017-04-05 04:15:50]

webexposed bits lgtm, but can you link to
https://groups.google.com/a/chromium.org/d/msg/blink-dev/0EW0_vT_MOU/rY-0w8ef...
in the description? (I often follow links from commits back to intents.)

[Adam Rice, 2017-04-05 05:43:54]

Description was changed from

==========
Ship ReadableStream pipeTo()

This involves removing the hack where out-of-line methods are defined as
internal functions in ReadableStream.js and then exported by
ReadableStreamExperimentalPipeTo.js. Now pipeThrough() and pipeTo() are defined
directly on the ReadableStream object.

ReadableStreamPipeTo() is still implemented as a separate function for
readability.

TBR=brettw@chromium.org
R=tyoshino@chromium.org
CC=domenic@chromium.org
BUG=668951
==========

to

==========
Ship ReadableStream pipeTo()

This involves removing the hack where out-of-line methods are defined as
internal functions in ReadableStream.js and then exported by
ReadableStreamExperimentalPipeTo.js. Now pipeThrough() and pipeTo() are defined
directly on the ReadableStream object.

ReadableStreamPipeTo() is still implemented as a separate function for
readability.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0EW0_vT_MOU/rY...

TBR=brettw@chromium.org
R=tyoshino@chromium.org
CC=domenic@chromium.org
BUG=668951
==========

[tyoshino (SeeGerritForStatus), 2017-04-05 06:08:41]

lgtm

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:224: //
assert(!binding.IsWritableStreamLocked(dest));
Please write some comment in natural language to explain the intention of these
lines.

[Adam Rice, 2017-04-05 07:03:47]

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2792513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:224: //
assert(!binding.IsWritableStreamLocked(dest));
On 2017/04/05 06:08:41, tyoshino wrote:
> Please write some comment in natural language to explain the intention of
these
> lines.

Done.

[Adam Rice, 2017-04-05 07:04:07]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-04-05 07:04:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2792513002/#ps40001
(title: "Add a comment explaining the purpose of the asserts in PipeTo")

[commit-bot: I haz the power, 2017-04-05 07:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 07:55:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[domenic, 2017-04-05 11:33:07]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2017-04-05 11:33:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2017-04-05 12:21:40]

lgtm ps3

[commit-bot: I haz the power, 2017-04-05 12:35:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491391987462840,
"parent_rev": "7cd5f9222a2687524aafc477a5416d3c60b6a261", "commit_rev":
"3f731a954bb05de9f166e427c507dac861cab0fc"}

[commit-bot: I haz the power, 2017-04-05 12:36:16]

Description was changed from

==========
Ship ReadableStream pipeTo()

This involves removing the hack where out-of-line methods are defined as
internal functions in ReadableStream.js and then exported by
ReadableStreamExperimentalPipeTo.js. Now pipeThrough() and pipeTo() are defined
directly on the ReadableStream object.

ReadableStreamPipeTo() is still implemented as a separate function for
readability.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0EW0_vT_MOU/rY...

TBR=brettw@chromium.org
R=tyoshino@chromium.org
CC=domenic@chromium.org
BUG=668951
==========

to

==========
Ship ReadableStream pipeTo()

This involves removing the hack where out-of-line methods are defined as
internal functions in ReadableStream.js and then exported by
ReadableStreamExperimentalPipeTo.js. Now pipeThrough() and pipeTo() are defined
directly on the ReadableStream object.

ReadableStreamPipeTo() is still implemented as a separate function for
readability.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0EW0_vT_MOU/rY...

TBR=brettw@chromium.org
R=tyoshino@chromium.org
CC=domenic@chromium.org
BUG=668951

Review-Url: https://codereview.chromium.org/2792513002
Cr-Commit-Position: refs/heads/master@{#462041}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f731a954bb05de9f166e427c507...
==========

[commit-bot: I haz the power, 2017-04-05 12:36:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3f731a954bb05de9f166e427c507...