Chromium Code Reviews
DescriptionFix two tests that started failing with PlzNavigate after browser-initiated navigations stopped going to the renderer first if there was no beforeunload handler in r460581.
The bug was that the tests were sending multiple navigations to different tabs in parallel. While a nested message loop was running for one navigation, the notification that about:blank (initial URL) of the tab was firing and causing the login interstitial (for the next navigation) to be removed. This doesn't happen in practice because we don't run nested message loops that dispatch IPCs in production, but we do for browser tests.
This fixes
LoginPromptBrowserTest.SupplyRedundantAuths
LoginPromptBrowserTest.CancelRedundantAuths
BUG=705559
Review-Url: https://codereview.chromium.org/2792493002
Cr-Commit-Position: refs/heads/master@{#461031}
Committed: https://chromium.googlesource.com/chromium/src/+/bc0329821f41940fff03c16dd1e36293d1042218
Patch Set 1 #
Messages
Total messages: 9 (5 generated)
|
|||||||||||||||||||