Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2792493002: Fix two tests that started failing with PlzNavigate after browser-initiated navigations stopped goi… (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, vabr+watchlistlogin_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two tests that started failing with PlzNavigate after browser-initiated navigations stopped going to the renderer first if there was no beforeunload handler in r460581. The bug was that the tests were sending multiple navigations to different tabs in parallel. While a nested message loop was running for one navigation, the notification that about:blank (initial URL) of the tab was firing and causing the login interstitial (for the next navigation) to be removed. This doesn't happen in practice because we don't run nested message loops that dispatch IPCs in production, but we do for browser tests. This fixes LoginPromptBrowserTest.SupplyRedundantAuths LoginPromptBrowserTest.CancelRedundantAuths BUG=705559 Review-Url: https://codereview.chromium.org/2792493002 Cr-Commit-Position: refs/heads/master@{#461031} Committed: https://chromium.googlesource.com/chromium/src/+/bc0329821f41940fff03c16dd1e36293d1042218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/ui/login/login_handler_browsertest.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jam
3 years, 8 months ago (2017-03-31 03:46:58 UTC) #2
nasko
LGTM
3 years, 8 months ago (2017-03-31 03:53:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792493002/1
3 years, 8 months ago (2017-03-31 03:54:43 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 04:35:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc0329821f41940fff03c16dd1e3...

Powered by Google App Engine
This is Rietveld 408576698