Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2792463002: [MD settings] set scroll target for custom word spellings subpage (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] set scroll target for custom word spellings subpage This CL adds the scroll target behavior to the edit dictionary subpage. The list of words may now extend to the bottom of the page without a scroll bar. When scrolling is needed, the scrollbar will appear on the side of the page (rather than just the words list). BUG=704007 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2792463002 Cr-Commit-Position: refs/heads/master@{#461189} Committed: https://chromium.googlesource.com/chromium/src/+/b87ba7ea439809c7a7ccd76a4ce55b1aae3aeeed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dschuyler
3 years, 8 months ago (2017-03-31 00:50:13 UTC) #5
hcarmona
lgtm
3 years, 8 months ago (2017-03-31 16:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792463002/1
3 years, 8 months ago (2017-03-31 18:20:13 UTC) #10
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
3 years, 8 months ago (2017-03-31 18:53:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792463002/1
3 years, 8 months ago (2017-03-31 19:24:42 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 19:54:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b87ba7ea439809c7a7ccd76a4ce5...

Powered by Google App Engine
This is Rietveld 408576698