Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2792253002: Remove a use of raster asset for VPN; update to MD. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a use of raster asset for VPN; update to MD. This is the icon seen in the vpn detailed page. The png is not removed because it's still used in //chrome/ and making that use network_icon.cc is blocked by DEPS rules --- a move/refactor of some sort will be necessary. BUG=690176 Review-Url: https://codereview.chromium.org/2792253002 Cr-Commit-Position: refs/heads/master@{#461731} Committed: https://chromium.googlesource.com/chromium/src/+/e1bc254c581e0fab52e1a3772cd1d21bd373e38e

Patch Set 1 #

Patch Set 2 : restore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M ash/common/system/chromeos/network/network_icon.cc View 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Evan Stade
3 years, 8 months ago (2017-04-04 03:02:48 UTC) #2
tdanderson
lgtm
3 years, 8 months ago (2017-04-04 15:00:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792253002/20001
3 years, 8 months ago (2017-04-04 15:04:14 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:45:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1bc254c581e0fab52e1a3772cd1...

Powered by Google App Engine
This is Rietveld 408576698