Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2792203003: Revert of Bluetooth: Add service data unit tests for chromeos (Closed)

Created:
3 years, 8 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 8 months ago
Reviewers:
Miao, rkc, ortuno, scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bluetooth: Add service data unit tests for chromeos (patchset #5 id:80001 of https://codereview.chromium.org/2783733002/ ) Reason for revert: This CL broke Mac build. Original issue's description: > Bluetooth: Add service data unit tests for chromeos > > This CL verifies that: > 1. service data is populated correctly during device creation. > 2. service data is updated correctly on property changed. > > BUG=688566 > > Review-Url: https://codereview.chromium.org/2783733002 > Cr-Commit-Position: refs/heads/master@{#461565} > Committed: https://chromium.googlesource.com/chromium/src/+/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5 TBR=ortuno@chromium.org,mcchou@chromium.org,rkc@chromium.org,scheib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688566 Review-Url: https://codereview.chromium.org/2792203003 Cr-Commit-Position: refs/heads/master@{#461584} Committed: https://chromium.googlesource.com/chromium/src/+/20e2934528d1d7332529212f6d7295ac87198107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -131 lines) Patch
M device/bluetooth/bluetooth_device_unittest.cc View 2 chunks +24 lines, -53 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 1 chunk +6 lines, -17 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 3 chunks +1 line, -30 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +2 lines, -10 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.cc View 2 chunks +10 lines, -19 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xiaoyinh(OOO Sep 11-29)
Created Revert of Bluetooth: Add service data unit tests for chromeos
3 years, 8 months ago (2017-04-04 00:06:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792203003/1
3 years, 8 months ago (2017-04-04 00:07:18 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 00:09:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20e2934528d1d7332529212f6d72...

Powered by Google App Engine
This is Rietveld 408576698