Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2792193002: Ignore start time values matching kNoTimestamp. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
tguilbert
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore start time values matching kNoTimestamp. ClusterFuzz seems to have honed in on providing a timestamp equal to std::numeric_limits<int64_t>::min(), which we use as a sentinal value meaning kNoTimestamp. These should be ignored, similarly to how we ignore AV_NOPTS_VALUE values when estimating start times. BUG=700501 TEST=clusterfuzz test case passes. Review-Url: https://codereview.chromium.org/2792193002 Cr-Commit-Position: refs/heads/master@{#461633} Committed: https://chromium.googlesource.com/chromium/src/+/ebc9c38753d2c3736fa96018bea462c64d1e6602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M media/filters/ffmpeg_demuxer.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
DaleCurtis
3 years, 8 months ago (2017-04-03 23:00:44 UTC) #2
tguilbert
LGTM
3 years, 8 months ago (2017-04-03 23:48:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792193002/1
3 years, 8 months ago (2017-04-04 00:10:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/422519)
3 years, 8 months ago (2017-04-04 01:18:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792193002/1
3 years, 8 months ago (2017-04-04 01:53:33 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 05:04:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebc9c38753d2c3736fa96018bea4...

Powered by Google App Engine
This is Rietveld 408576698