Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ui/base/dragdrop/os_exchange_data.h

Issue 2792183002: Delete ash-based code for Windows drag-and-drop graphics. (Closed)
Patch Set: ashdrag: addheaders Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/dragdrop/drag_utils_win.cc ('k') | ui/base/dragdrop/os_exchange_data_provider_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/dragdrop/os_exchange_data.h
diff --git a/ui/base/dragdrop/os_exchange_data.h b/ui/base/dragdrop/os_exchange_data.h
index 683197de275155f86cc1006e2747d221abd83d19..282587d23df8113812d304194c41d196e61defaa 100644
--- a/ui/base/dragdrop/os_exchange_data.h
+++ b/ui/base/dragdrop/os_exchange_data.h
@@ -133,8 +133,8 @@ class UI_BASE_EXPORT OSExchangeData {
#if defined(USE_AURA) || defined(OS_MACOSX)
virtual void SetDragImage(const gfx::ImageSkia& image,
const gfx::Vector2d& cursor_offset) = 0;
- virtual const gfx::ImageSkia& GetDragImage() const = 0;
- virtual const gfx::Vector2d& GetDragImageOffset() const = 0;
sadrul 2017/04/19 17:04:50 Was this a deliberate change? Can you document the
danakj 2017/04/19 17:20:22 Yes, because the win one doesn't have anything to
+ virtual gfx::ImageSkia GetDragImage() const = 0;
+ virtual gfx::Vector2d GetDragImageOffset() const = 0;
#endif
};
« no previous file with comments | « ui/base/dragdrop/drag_utils_win.cc ('k') | ui/base/dragdrop/os_exchange_data_provider_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698