Delete ash-based code for Windows drag-and-drop graphics.

ui/base/dragdrop/os_exchange_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_DRAGDROP_OS_EXCHANGE_DATA_H_
 #define UI_BASE_DRAGDROP_OS_EXCHANGE_DATA_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 115 matching lines @@
 
 #if defined(USE_AURA)
     virtual void SetHtml(const base::string16& html, const GURL& base_url) = 0;
     virtual bool GetHtml(base::string16* html, GURL* base_url) const = 0;
     virtual bool HasHtml() const = 0;
 #endif
 
 #if defined(USE_AURA) || defined(OS_MACOSX)
     virtual void SetDragImage(const gfx::ImageSkia& image,
                               const gfx::Vector2d& cursor_offset) = 0;
-    virtual const gfx::ImageSkia& GetDragImage() const = 0;
-    virtual const gfx::Vector2d& GetDragImageOffset() const = 0;

[sadrul, 2017/04/19 17:04:50]

Was this a deliberate change? Can you document the reason in the CL description?

[danakj, 2017/04/19 17:20:22]

Yes, because the win one doesn't have anything to return, but this requires
non-local storage of an object to return. So it would have to make a static
variable or something weird for NOTREACHED() code.

+    virtual gfx::ImageSkia GetDragImage() const = 0;
+    virtual gfx::Vector2d GetDragImageOffset() const = 0;
 #endif
   };
 
   OSExchangeData();
   // Creates an OSExchangeData with the specified provider. OSExchangeData
   // takes ownership of the supplied provider.
   explicit OSExchangeData(std::unique_ptr<Provider> provider);
 
   ~OSExchangeData();
 
@@ skipping 79 matching lines @@
  private:
   // Provides the actual data.
   std::unique_ptr<Provider> provider_;
 
   DISALLOW_COPY_AND_ASSIGN(OSExchangeData);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_DRAGDROP_OS_EXCHANGE_DATA_H_