Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Also move histogram MobileOmnibox.PressedClipboardSuggestionAge from the internal google repository to histograms.xml.  In the process, expand the histogram description and revise the owners of this histogram.

Tested using about:histograms.

BUG=704715
Review-Url: https://codereview.chromium.org/2792173004
Cr-Commit-Position: refs/heads/master@{#463093}
Committed: https://chromium.googlesource.com/chromium/src/+/d3dcdb05fa128fc8958a5772734847198324e25b

[Mark P, 2017-04-04 22:46:28]

Description was changed from

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

BUG=704715
==========

to

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Tested using about:histograms.

BUG=704715
==========

[Mark P, 2017-04-04 22:54:43]

mpearson@chromium.org changed reviewers:
+ isherman@chromium.org, jif@chromium.org

[Mark P, 2017-04-04 22:54:44]

jif@ and isherman@,

Can you please both review this changelist?

thanks,
mark

[Mark P, 2017-04-04 22:55:49]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 22:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 00:39:36]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-04-05 01:35:56]

https://codereview.chromium.org/2792173004/diff/1/components/omnibox/browser/...
File components/omnibox/browser/clipboard_url_provider.cc (right):

https://codereview.chromium.org/2792173004/diff/1/components/omnibox/browser/...
components/omnibox/browser/clipboard_url_provider.cc:57:
clipboard_content_->GetClipboardContentAge());
Just to confirm: Does this histogram really need 100 buckets rather than the
standard 50?  If so, what's the motivation?  (Should we be recommending 100
buckets more broadly, or is this metric unusual?)

[Mark P, 2017-04-05 04:16:39]

Description was changed from

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Tested using about:histograms.

BUG=704715
==========

to

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Also move histogram MobileOmnibox.PressedClipboardSuggestionAge from the
internal google repository to histograms.xml.  In the process, expand the
histogram description and revise the owners of this histogram.

Tested using about:histograms.

BUG=704715
==========

[Mark P, 2017-04-05 04:17:57]

https://codereview.chromium.org/2792173004/diff/1/components/omnibox/browser/...
File components/omnibox/browser/clipboard_url_provider.cc (right):

https://codereview.chromium.org/2792173004/diff/1/components/omnibox/browser/...
components/omnibox/browser/clipboard_url_provider.cc:57:
clipboard_content_->GetClipboardContentAge());
On 2017/04/05 01:35:56, Ilya Sherman wrote:
> Just to confirm: Does this histogram really need 100 buckets rather than the
> standard 50?  If so, what's the motivation?  (Should we be recommending 100
> buckets more broadly, or is this metric unusual?)

I used this UMA macro so the data is comparable to another histogram.

Which reminds me, I'll expand the histogram description to mention that.

Also, I'll add the histogram to this file.  (It was previously in the internal
repository.)

[jif, 2017-04-05 16:16:18]

thanks for moving PressedClipboardSuggestionAge

lgtm

[Ilya Sherman, 2017-04-05 21:53:23]

LGTM, thanks.

https://codereview.chromium.org/2792173004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2792173004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29833: +    the clipboard.
It might be helpful to document what's recorded if Chrome never detected a
change (or to otherwise clarify what the default/initial state is).

[Mark P, 2017-04-05 22:08:28]

https://codereview.chromium.org/2792173004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2792173004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29833: +    the clipboard.
On 2017/04/05 21:53:23, Ilya Sherman wrote:
> It might be helpful to document what's recorded if Chrome never detected a
> change (or to otherwise clarify what the default/initial state is).

Good idea.  Clarified both.

[Mark P, 2017-04-07 22:50:49]

I'm assuming the clarifications are fine.  Submitting.

--mark

[Mark P, 2017-04-07 22:53:00]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2017-04-07 22:53:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2792173004/#ps40001
(title: "clarified histograms")

[commit-bot: I haz the power, 2017-04-07 22:53:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-04-08 00:16:20]

Yep, the clarifications are good -- thanks!  (Still LGTM)

[commit-bot: I haz the power, 2017-04-08 01:11:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491605580691330,
"parent_rev": "7d4310f9cdb95ab5a7950eedb1c4fd77254f7246", "commit_rev":
"d3dcdb05fa128fc8958a5772734847198324e25b"}

[commit-bot: I haz the power, 2017-04-08 01:11:58]

Description was changed from

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Also move histogram MobileOmnibox.PressedClipboardSuggestionAge from the
internal google repository to histograms.xml.  In the process, expand the
histogram description and revise the owners of this histogram.

Tested using about:histograms.

BUG=704715
==========

to

==========
Omnibox Metrics - Record Age of Clipboard Suggestions Shown

Also move histogram MobileOmnibox.PressedClipboardSuggestionAge from the
internal google repository to histograms.xml.  In the process, expand the
histogram description and revise the owners of this histogram.

Tested using about:histograms.

BUG=704715

Review-Url: https://codereview.chromium.org/2792173004
Cr-Commit-Position: refs/heads/master@{#463093}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3dcdb05fa128fc8958a57727348...
==========

[commit-bot: I haz the power, 2017-04-08 01:11:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d3dcdb05fa128fc8958a57727348...