Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/common/extensions/api/settings_private.idl

Issue 2792163003: chrome.settingsPrivate: Check whitelist for getPref / setPref (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/settings_private.idl
diff --git a/chrome/common/extensions/api/settings_private.idl b/chrome/common/extensions/api/settings_private.idl
index 0f1900688b30b7fb2360c6d4d7cc44485a944da4..f998ee3c0ab81f4e1715e78f6b311209ba8f9498 100644
--- a/chrome/common/extensions/api/settings_private.idl
+++ b/chrome/common/extensions/api/settings_private.idl
@@ -3,7 +3,8 @@
// found in the LICENSE file.
// Use the <code>chrome.settingsPrivate</code> API to get or set preferences
-// from the settings UI.
+// from the settings UI. Access is restricted to a whitelisted set of user
michaelpg 2017/04/04 00:37:09 nit: user-facing
stevenjb 2017/04/04 18:18:11 meh
+// facing preferences.
namespace settingsPrivate {
enum PrefType { BOOLEAN, NUMBER, STRING, URL, LIST, DICTIONARY };
@@ -58,7 +59,7 @@ namespace settingsPrivate {
callback SetDefaultZoomCallback = void (boolean success);
interface Functions {
- // Sets a settings value.
+ // Sets a pref value.
// |name|: The name of the pref.
// |value|: The new value of the pref.
// |pageId|: The user metrics identifier or null.

Powered by Google App Engine
This is Rietveld 408576698