chrome.settingsPrivate: Check whitelist for getPref / setPref

chrome/common/extensions/api/settings_private.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.settingsPrivate</code> API to get or set preferences
-// from the settings UI.
+// from the settings UI. Access is restricted to a whitelisted set of user

[michaelpg, 2017/04/04 00:37:09]

nit: user-facing

[stevenjb, 2017/04/04 18:18:11]

meh

+// facing preferences.
 namespace settingsPrivate {
   enum PrefType { BOOLEAN, NUMBER, STRING, URL, LIST, DICTIONARY };
 
   enum ControlledBy {
     DEVICE_POLICY,
     USER_POLICY,
     OWNER,
     PRIMARY_USER,
     EXTENSION
   };
@@ skipping 34 matching lines @@
     boolean? extensionCanBeDisabled;
   };
 
   callback OnPrefSetCallback = void (boolean success);
   callback GetAllPrefsCallback = void (PrefObject[] prefs);
   callback GetPrefCallback = void (PrefObject pref);
   callback GetDefaultZoomCallback = void (double zoom);
   callback SetDefaultZoomCallback = void (boolean success);
 
   interface Functions {
-    // Sets a settings value.
+    // Sets a pref value.
     // |name|: The name of the pref.
     // |value|: The new value of the pref.
     // |pageId|: The user metrics identifier or null.
     // |callback|: The callback for whether the pref was set or not.
     static void setPref(DOMString name, any value,
         DOMString pageId, OnPrefSetCallback callback);
 
     // Gets an array of all the prefs.
     static void getAllPrefs(GetAllPrefsCallback callback);
 
@@ skipping 10 matching lines @@
         double zoom, optional SetDefaultZoomCallback callback);
   };
 
   interface Events {
     // Fired when a set of prefs has changed.
     //
     // |prefs| The prefs that changed.
     static void onPrefsChanged(PrefObject[] prefs);
   };
 };