Paint: remove readPixels.

This patch removes readPixels from PaintCanvas.

Most of the changes replace canvas read pixels call in favor
of first getting the bitmap, and then doing a readpixels on that.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2792133002
Cr-Commit-Position: refs/heads/master@{#462984}
Committed: https://chromium.googlesource.com/chromium/src/+/80f046dd33d3e07eb83a116a74b7c079cded4b82

[vmpstr, 2017-04-03 19:54:47]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:55:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 20:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 20:03:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-04-03 20:32:49]

Description was changed from

==========
test

BUG=
==========

to

==========
test

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-04-03 20:32:54]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 20:45:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 20:45:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vmpstr, 2017-04-03 21:45:42]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-04-03 21:46:37]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:47:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-04-03 22:56:30]

Description was changed from

==========
test

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
This patch removes readPixels from PaintCanvas.

Most of the changes replace canvas read pixels call in favor
of first getting the bitmap, and then doing a readpixels on that.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-04-03 22:56:30]

vmpstr@chromium.org changed reviewers:
+ enne@chromium.org

[vmpstr, 2017-04-03 22:58:31]

Please take a look.

danakj@ is removing ImageRep stuff, so I will wait until that lands, but overall
the rest of the changes should remain.

[commit-bot: I haz the power, 2017-04-04 00:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 00:15:31]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-04-04 00:23:22]

lgtm, thanks!!

[vmpstr, 2017-04-05 00:14:12]

vmpstr@chromium.org changed reviewers:
+ dalecurtis@chromium.org, sky@chromium.org

[vmpstr, 2017-04-05 00:14:12]

+sky for ash/ and ui/
+dalecurtis for media/

Please take a look.

[sky, 2017-04-05 03:00:25]

LGTM

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:109: // |copyTo| will perform a deep copy, which is what we
want.
Generally we use |s for references to variables and parameters, and () for
references to functions, e.g. copyTo() here.

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:111: DCHECK(result);
Document why result should be true here.

[vmpstr, 2017-04-05 18:49:44]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:50:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:55:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vmpstr, 2017-04-05 19:13:39]

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:109: // |copyTo| will perform a deep copy, which is what we
want.
On 2017/04/05 03:00:24, sky wrote:
> Generally we use |s for references to variables and parameters, and () for
> references to functions, e.g. copyTo() here.

Done.

https://codereview.chromium.org/2792133002/diff/60001/ui/gfx/canvas.cc#newcod...
ui/gfx/canvas.cc:111: DCHECK(result);
On 2017/04/05 03:00:24, sky wrote:
> Document why result should be true here.

Done.

[DaleCurtis, 2017-04-05 23:17:48]

media/ lgtm

[vmpstr, 2017-04-07 17:32:05]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-04-07 17:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2792133002/#ps100001
(title: "update")

[commit-bot: I haz the power, 2017-04-07 17:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:21:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491586325471290,
"parent_rev": "24d1d608245a0e164b9d1081a322de8df4cf2887", "commit_rev":
"80f046dd33d3e07eb83a116a74b7c079cded4b82"}

[commit-bot: I haz the power, 2017-04-07 20:26:14]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491586325471290,
"parent_rev": "24d1d608245a0e164b9d1081a322de8df4cf2887", "commit_rev":
"80f046dd33d3e07eb83a116a74b7c079cded4b82"}

[commit-bot: I haz the power, 2017-04-07 20:26:17]

Description was changed from

==========
This patch removes readPixels from PaintCanvas.

Most of the changes replace canvas read pixels call in favor
of first getting the bitmap, and then doing a readpixels on that.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
This patch removes readPixels from PaintCanvas.

Most of the changes replace canvas read pixels call in favor
of first getting the bitmap, and then doing a readpixels on that.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2792133002
Cr-Commit-Position: refs/heads/master@{#462984}
Committed:
https://chromium.googlesource.com/chromium/src/+/80f046dd33d3e07eb83a116a74b7...
==========

[commit-bot: I haz the power, 2017-04-07 20:26:18]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/80f046dd33d3e07eb83a116a74b7...