Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 279213002: [fsp] Add support for closing files. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

[fsp] Add support for closing files. This patch adds support for closing files. It is currently a no-op, and it is not yet bound to fileapi. TEST=chromium: *FileSystemProvider*CloseFile* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270116

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -119 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 2 chunks +21 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/close_file.h View 3 chunks +11 lines, -15 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/operations/close_file.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 6 chunks +42 lines, -61 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 3 chunks +28 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtomasz
This CL depends on 284443002. @benwells: PTAL at IDL. @kinaba: PTAL at C++. Thanks.
6 years, 7 months ago (2014-05-13 01:17:20 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-13 01:39:32 UTC) #2
benwells
lgtm
6 years, 7 months ago (2014-05-13 01:53:30 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-13 07:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/279213002/40002
6 years, 7 months ago (2014-05-13 07:34:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 09:17:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 10:37:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153387)
6 years, 7 months ago (2014-05-13 10:37:12 UTC) #8
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-13 13:38:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/279213002/40002
6 years, 7 months ago (2014-05-13 13:38:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 15:01:13 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 16:13:48 UTC) #12
Message was sent while issue was closed.
Change committed as 270116

Powered by Google App Engine
This is Rietveld 408576698