[fsp] Add support for closing files.

chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 34 matching lines @@
  private:
   ScopedVector<extensions::Event> events_;
   bool dispatch_reply_;
 
   DISALLOW_COPY_AND_ASSIGN(LoggingDispatchEventImpl);
 };
 
 // Callback invocation logger. Acts as a fileapi end-point.
 class CallbackLogger {
  public:
+  class Event {
+   public:
+    Event(int file_handle, base::File::Error result)
+        : file_handle_(file_handle), result_(result) {}
+    virtual ~Event() {}
+
+    int file_handle() { return file_handle_; }
+    base::File::Error result() { return result_; }
+
+   private:
+    int file_handle_;
+    base::File::Error result_;
+
+    DISALLOW_COPY_AND_ASSIGN(Event);
+  };
+
   CallbackLogger() : weak_ptr_factory_(this) {}
   virtual ~CallbackLogger() {}
 
-  void OnOpenFile(base::File::Error result) { events_.push_back(result); }
+  void OnOpenFile(int file_handle, base::File::Error result) {
+    events_.push_back(new Event(file_handle, result));
+  }
 
-  std::vector<base::File::Error>& events() { return events_; }
+  ScopedVector<Event>& events() { return events_; }
 
   base::WeakPtr<CallbackLogger> GetWeakPtr() {
     return weak_ptr_factory_.GetWeakPtr();
   }
 
  private:
-  std::vector<base::File::Error> events_;
+  ScopedVector<Event> events_;
+  bool dispatch_reply_;
   base::WeakPtrFactory<CallbackLogger> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CallbackLogger);
 };
 
 }  // namespace
 
 class FileSystemProviderOperationsOpenFileTest : public testing::Test {
  protected:
   FileSystemProviderOperationsOpenFileTest() {}
@@ skipping 95 matching lines @@
   open_file.SetDispatchEventImplForTesting(
       base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(open_file.Execute(kRequestId));
 
   open_file.OnSuccess(kRequestId,
                       scoped_ptr<RequestValue>(new RequestValue()),
                       false /* has_next */);
   ASSERT_EQ(1u, callback_logger.events().size());
-  EXPECT_EQ(base::File::FILE_OK, callback_logger.events()[0]);
+  CallbackLogger::Event* event = callback_logger.events()[0];
+  EXPECT_EQ(base::File::FILE_OK, event->result());
+  EXPECT_LT(0, event->file_handle());
 }
 
 TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {
   using extensions::api::file_system_provider::EntryMetadata;
   using extensions::api::file_system_provider_internal::OpenFileRequestedError::
       Params;
 
   LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   CallbackLogger callback_logger;
 
   OpenFile open_file(
       NULL,
       file_system_info_,
       base::FilePath::FromUTF8Unsafe(kFilePath),
       ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,
       false /* create */,
       base::Bind(&CallbackLogger::OnOpenFile, callback_logger.GetWeakPtr()));
   open_file.SetDispatchEventImplForTesting(
       base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(open_file.Execute(kRequestId));
 
   open_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
   ASSERT_EQ(1u, callback_logger.events().size());
-  EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED,
-            callback_logger.events()[0]);
+  CallbackLogger::Event* event = callback_logger.events()[0];
+  EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
+  ASSERT_EQ(0, event->file_handle());
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos