Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2792063004: Reland of [heap] Fix CompactionSpace test and move to unittests (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Fix CompactionSpace test and move to unittests This reverts commit eddf90c4a750f88c75c11f344675f27942da0400. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2792063004 Cr-Commit-Position: refs/heads/master@{#44398} Committed: https://chromium.googlesource.com/v8/v8/+/a0655790ae565895cbeb3986eb762021acf9ae26

Patch Set 1 : baseline #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/heap/spaces-unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Lippautz
3 years, 8 months ago (2017-04-04 15:07:27 UTC) #5
ulan
lgtm
3 years, 8 months ago (2017-04-04 15:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792063004/20001
3 years, 8 months ago (2017-04-05 07:14:18 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:36:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a0655790ae565895cbeb3986eb762021acf...

Powered by Google App Engine
This is Rietveld 408576698