Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2792053002: Scan generic method comments with Fasta. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -103 lines) Patch
M pkg/analyzer/lib/src/fasta/token_utils.dart View 2 chunks +16 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 4 chunks +91 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 4 chunks +0 lines, -65 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/precedence.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token_constants.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 2 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-03 16:30:45 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-03 18:48:46 UTC) #2
scheglov
3 years, 8 months ago (2017-04-03 19:02:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed1152fe8d1d96ac601844a85a12162fadaad61c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698