Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart

Issue 2792053002: Scan generic method comments with Fasta. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
index 3affe47d4ceb5ba467ee28e6c2f992eebba8cb92..af33e05b1c9d4dcb2c6d368143dea9d61392fd03 100644
--- a/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
@@ -13,8 +13,6 @@ import 'precedence.dart' show PrecedenceInfo;
import 'token.dart'
show
BeginGroupToken,
- CommentToken,
- DartDocToken,
KeywordToken,
StringToken,
SymbolToken,
@@ -48,20 +46,6 @@ abstract class ArrayBasedScanner extends AbstractScanner {
Link<BeginGroupToken> groupingStack = const Link<BeginGroupToken>();
/**
- * Append the given token to the [tail] of the current stream of tokens.
- */
- void appendToken(Token token) {
- tail.next = token;
- tail.next.previousToken = tail;
- tail = tail.next;
- if (comments != null) {
- tail.precedingCommentTokens = comments;
- comments = null;
- commentsTail = null;
- }
- }
-
- /**
* Appends a fixed token whose kind and content is determined by [info].
* Appends an *operator* token from [info].
*
@@ -231,29 +215,6 @@ abstract class ArrayBasedScanner extends AbstractScanner {
}
}
- void appendComment(start, PrecedenceInfo info, bool asciiOnly) {
- if (!includeComments) return;
- Token newComment = createCommentToken(info, start, asciiOnly);
- _appendToCommentStream(newComment);
- }
-
- void appendDartDoc(start, PrecedenceInfo info, bool asciiOnly) {
- if (!includeComments) return;
- Token newComment = createDartDocToken(info, start, asciiOnly);
- _appendToCommentStream(newComment);
- }
-
- void _appendToCommentStream(Token newComment) {
- if (comments == null) {
- comments = newComment;
- commentsTail = comments;
- } else {
- commentsTail.next = newComment;
- commentsTail.next.previousToken = commentsTail;
- commentsTail = commentsTail.next;
- }
- }
-
void appendErrorToken(ErrorToken token) {
hasErrors = true;
appendToken(token);
@@ -278,32 +239,6 @@ abstract class ArrayBasedScanner extends AbstractScanner {
[int extraOffset = 0]);
/**
- * Returns a new comment from the scan offset [start] to the current
- * [scanOffset] plus the [extraOffset]. For example, if the current
- * scanOffset is 10, then [appendSubstringToken(5, -1)] will append the
- * substring string [5,9).
- *
- * Note that [extraOffset] can only be used if the covered character(s) are
- * known to be ASCII.
- */
- CommentToken createCommentToken(
- PrecedenceInfo info, int start, bool asciiOnly,
- [int extraOffset = 0]);
-
- /**
- * Returns a new dartdoc from the scan offset [start] to the current
- * [scanOffset] plus the [extraOffset]. For example, if the current
- * scanOffset is 10, then [appendSubstringToken(5, -1)] will append the
- * substring string [5,9).
- *
- * Note that [extraOffset] can only be used if the covered character(s) are
- * known to be ASCII.
- */
- DartDocToken createDartDocToken(
- PrecedenceInfo info, int start, bool asciiOnly,
- [int extraOffset = 0]);
-
- /**
* This method is called to discard '<' from the "grouping" stack.
*
* [PartialParser.skipExpression] relies on the fact that we do not
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart ('k') | pkg/front_end/lib/src/fasta/scanner/precedence.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698